Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2807033002:
Compile file_table_list in gyp v2 (Closed)
|
Created:
3 years, 8 months ago by oka Modified:
3 years, 8 months ago Reviewers:
fukino CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionCompile file_table_list in gyp v2
To remove circular deps between file_table and file_table_list,
- Moved filelist namespace from file_table to file_table_list.
- Use observer pattern instead of calling
|updateHighPriorityRange| in FileTable from FileTableList.
BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2807033002
Cr-Commit-Position: refs/heads/master@{#464336}
Committed: https://chromium.googlesource.com/chromium/src/+/1d72f2db0caadf203009ff249b8108daaa4ad8dd
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #
Total comments: 4
Patch Set 4 : address comments. #Patch Set 5 : Format. #Patch Set 6 : Revert unintended format. #
Depends on Patchset: Messages
Total messages: 30 (18 generated)
Description was changed from ========== Compile file_table_list. BUG= ========== to ========== Compile file_table_list. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Compile file_table_list. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Compile file_table_list in gyp v2 BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Compile file_table_list in gyp v2 BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Compile file_table_list in gyp v2 BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
oka@chromium.org changed reviewers: + fukino@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Please check the test failures
.
Description was changed from ========== Compile file_table_list in gyp v2 BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Compile file_table_list in gyp v2 To remove circular deps between file_table and file_table_list, - Moved filelist namespace from file_table to file_table_list. - Use observer pattern instead of calling |updateHighPriorityRange| in FileTable from FileTableList. BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
.
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Fixed the tests. PTAL.
Description was changed from ========== Compile file_table_list in gyp v2 To remove circular deps between file_table and file_table_list, - Moved filelist namespace from file_table to file_table_list. - Use observer pattern instead of calling |updateHighPriorityRange| in FileTable from FileTableList. BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Compile file_table_list in gyp v2 To remove circular deps between file_table and file_table_list, - Moved filelist namespace from file_table to file_table_list. - Use observer pattern instead of calling |updateHighPriorityRange| in FileTable from FileTableList. BUG=636289 TEST=run_compiler, try CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm with nits. https://codereview.chromium.org/2807033002/diff/40001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/ui/file_table_list.js (right): https://codereview.chromium.org/2807033002/diff/40001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/file_table_list.js:33: FileTableList.prototype.onMergeItems_; nit: = null, and @type {?function(number, number)} https://codereview.chromium.org/2807033002/diff/40001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/file_table_list.js:60: this.onMergeItems_(beginIndex, endIndex); nit: add "if (this.onMergeItems_)"
address comments.
Format.
Revert unintended format.
The CQ bit was checked by oka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org Link to the patchset: https://codereview.chromium.org/2807033002/#ps100001 (title: "Revert unintended format.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492068923938160,
"parent_rev": "9f00423812b73080001e1742d6ad356c68c23b62", "commit_rev":
"1d72f2db0caadf203009ff249b8108daaa4ad8dd"}
Message was sent while issue was closed.
Description was changed from ========== Compile file_table_list in gyp v2 To remove circular deps between file_table and file_table_list, - Moved filelist namespace from file_table to file_table_list. - Use observer pattern instead of calling |updateHighPriorityRange| in FileTable from FileTableList. BUG=636289 TEST=run_compiler, try CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Compile file_table_list in gyp v2 To remove circular deps between file_table and file_table_list, - Moved filelist namespace from file_table to file_table_list. - Use observer pattern instead of calling |updateHighPriorityRange| in FileTable from FileTableList. BUG=636289 TEST=run_compiler, try CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2807033002 Cr-Commit-Position: refs/heads/master@{#464336} Committed: https://chromium.googlesource.com/chromium/src/+/1d72f2db0caadf203009ff249b81... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/1d72f2db0caadf203009ff249b81...
Message was sent while issue was closed.
https://codereview.chromium.org/2807033002/diff/40001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/ui/file_table_list.js (right): https://codereview.chromium.org/2807033002/diff/40001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/file_table_list.js:33: FileTableList.prototype.onMergeItems_; On 2017/04/13 07:08:18, fukino wrote: > nit: = null, and @type {?function(number, number)} Done. https://codereview.chromium.org/2807033002/diff/40001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/ui/file_table_list.js:60: this.onMergeItems_(beginIndex, endIndex); On 2017/04/13 07:08:18, fukino wrote: > nit: add "if (this.onMergeItems_)" Done. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
