Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2779663002: Compile cr.ui.Table and cr.ui.table.* in gyp v2 (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile cr.ui.Table and cr.ui.table.* in gyp v2 - Replaced all occurrences of cr.ui.Table in cr/ui/table/* to Element. - Moved renderFunction_ in TableList, which uses the knowledge that cr.ui.Table has columnModel, to cr.ui.Table. BUG=705527 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2779663002 Cr-Commit-Position: refs/heads/master@{#460309} Committed: https://chromium.googlesource.com/chromium/src/+/068669c24287ba5fbd0b541649ecc65fa08019ee

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -39 lines) Patch
M ui/webui/resources/js/cr/ui/compiled_resources2.gyp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/table.js View 1 2 3 2 chunks +31 lines, -3 lines 0 comments Download
A ui/webui/resources/js/cr/ui/table/compiled_resources2.gyp View 1 chunk +49 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/table/table_column.js View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/webui/resources/js/cr/ui/table/table_column_model.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/js/cr/ui/table/table_header.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/table/table_list.js View 1 2 3 chunks +2 lines, -27 lines 0 comments Download
M ui/webui/resources/js/cr/ui/table/table_splitter.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 32 (21 generated)
oka
.
3 years, 8 months ago (2017-03-28 01:25:19 UTC) #2
oka
.
3 years, 8 months ago (2017-03-28 05:38:50 UTC) #7
oka
PTAL.
3 years, 8 months ago (2017-03-28 05:50:07 UTC) #13
Dan Beam
lgtm https://codereview.chromium.org/2779663002/diff/40001/ui/webui/resources/js/cr/ui/table.js File ui/webui/resources/js/cr/ui/table.js (right): https://codereview.chromium.org/2779663002/diff/40001/ui/webui/resources/js/cr/ui/table.js#newcode134 ui/webui/resources/js/cr/ui/table.js:134: @private
3 years, 8 months ago (2017-03-28 13:05:56 UTC) #16
oka
.
3 years, 8 months ago (2017-03-28 13:09:26 UTC) #17
oka
Thanks! https://codereview.chromium.org/2779663002/diff/40001/ui/webui/resources/js/cr/ui/table.js File ui/webui/resources/js/cr/ui/table.js (right): https://codereview.chromium.org/2779663002/diff/40001/ui/webui/resources/js/cr/ui/table.js#newcode134 ui/webui/resources/js/cr/ui/table.js:134: On 2017/03/28 13:05:56, Dan Beam (slow) wrote: > ...
3 years, 8 months ago (2017-03-28 13:12:35 UTC) #18
commit-bot: I haz the power
This CL has an open dependency (Issue 2781533002 Patch 20001). Please resolve the dependency and ...
3 years, 8 months ago (2017-03-28 13:13:09 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779663002/60001
3 years, 8 months ago (2017-03-28 23:54:47 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/259804)
3 years, 8 months ago (2017-03-29 01:40:42 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779663002/60001
3 years, 8 months ago (2017-03-29 05:09:09 UTC) #29
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 07:09:47 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/068669c24287ba5fbd0b541649ec...

Powered by Google App Engine
This is Rietveld 408576698