Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js

Issue 2805853002: Compile suggest_app_dialog in gyp v2 (Closed)
Patch Set: Fix unit test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
diff --git a/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js b/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
index 14554b7cc422436b2afbad45ba06cf63858fbc3e..462feed143d14727144d1fb47db67e73dfc66421 100644
--- a/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
+++ b/components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
@@ -45,7 +45,7 @@ var CWS_WIDGET_ORIGIN = 'https://clients5.google.com';
*
* @param {!HTMLDocument} document The document to contain this container.
* @param {!HTMLElement} parentNode Node to be parent for this container.
- * @param {!CWSWidgetContainer.PlatformDelegate} delegate Delegate for accessing
+ * @param {!CWSWidgetContainerPlatformDelegate} delegate Delegate for accessing
* Chrome platform APIs.
* @param {!{
* overrideCwsContainerUrlForTest: (string|undefined),
@@ -54,7 +54,7 @@ var CWS_WIDGET_ORIGIN = 'https://clients5.google.com';
* @constructor
*/
function CWSWidgetContainer(document, parentNode, delegate, params) {
- /** @private {!CWSWidgetContainer.PlatformDelegate} */
+ /** @private {!CWSWidgetContainerPlatformDelegate} */
this.delegate_ = delegate;
/** @private {!CWSWidgetContainer.MetricsRecorder} */
@@ -217,42 +217,6 @@ function CWSWidgetContainer(document, parentNode, delegate, params) {
}
/**
- * Strings required by the widget container.
- * @typedef {{
- * UI_LOCALE: string,
- * LINK_TO_WEBSTORE: string,
- * INSTALLATION_FAILED_MESSAGE: string,
- * LOADING_SPINNER_ALT: string,
- * INSTALLING_SPINNER_ALT: string
- * }}
- */
-CWSWidgetContainer.Strings;
-
-/**
- * Functions for reporting metrics for the widget.
- * @typedef {{
- * recordEnum: function(string, number, number),
- * recordUserAction: function(string),
- * startInterval: function(string),
- * recordInterval: function(string)
- * }}
- */
-CWSWidgetContainer.MetricsImpl;
-
-/**
- * Type for delegate used by CWSWidgetContainer component to access Chrome
- * platform APIs.
- * @typedef {{
- * strings: !CWSWidgetContainer.Strings,
- * metricsImpl: !CWSWidgetContainer.MetricsImpl,
- * installWebstoreItem: function(string, function(?string)),
- * getInstalledItems: function(function(?Array<!string>)),
- * requestWebstoreAccessToken: function(function(?string))
- * }}
- */
-CWSWidgetContainer.PlatformDelegate;
-
-/**
* @enum {string}
* @private
*/
@@ -878,11 +842,11 @@ CWSWidgetContainer.SpinnerLayerController.prototype.setVisible =
/**
* Utility methods and constants to record histograms.
- * @param {!CWSWidgetContainer.MetricsImpl} metricsImpl
+ * @param {!CWSWidgetContainerMetricsImpl} metricsImpl
* @constructor
*/
CWSWidgetContainer.MetricsRecorder = function(metricsImpl) {
- /** @private {!CWSWidgetContainer.MetricsImpl} */
+ /** @private {!CWSWidgetContainerMetricsImpl} */
this.metricsImpl_ = metricsImpl;
};

Powered by Google App Engine
This is Rietveld 408576698