ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js - Issue 2805853002: Compile suggest_app_dialog in gyp v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

Issue 2805853002: Compile suggest_app_dialog in gyp v2 (Closed)

Patch Set: Fix unit test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp ('k') | ui/file_manager/file_manager/foreground/js/web_store_utils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js b/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

index f9a2d9d3055b8cd0e940a436cacd0350bccb34f7..82d89188451712df161419223f60d994c18759f1 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

@@ -100,10 +100,8 @@ SuggestAppsDialog.prototype.showByExtensionAndMime =

if (mime)

options.mime_type = mime;

this.showInternal_(

- options,

- str('SUGGEST_DIALOG_TITLE'),

- FileTasks.createWebStoreLink(extension, mime),

- onDialogClosed);

+ options, str('SUGGEST_DIALOG_TITLE'),

+ webStoreUtils.createWebStoreLink(extension, mime), onDialogClosed);

};

/**

@@ -124,7 +122,7 @@ SuggestAppsDialog.prototype.showProviders = function(onDialogClosed) {

/**

* Creates platform delegate for CWSWidgetContainer.

- * @return {!CWSWidgetContainer.PlatformDelegate}

+ * @return {!CWSWidgetContainerPlatformDelegate}

* @private

SuggestAppsDialog.prototype.createWidgetPlatformDelegate_ = function() {