Check in the libxml roll script.

Check in the libxml roll script.

This rolls libxml to the same upstream point,
e905f08123e4a6e7731549e6f09dadff4cab65bd, but with these important
differences:

- The script which does the roll is included along with the roll
  itself.

- libxml2 src used to be patched with a mixture of sed, git
  cherry-pick, and patch. Now there is just a set of patch files in
  chromium/*.patch. This should make the delta to libxml2 more
  transparent. When a patch needs to be rebased, the changes to the
  patch file should be committed along with the roll.

- libxml2's features are now done with configure flags instead of
  editing the xmlversion.h headers.

- More unused files are deleted. This makes it clearer what may
  actually be built into Chromium.

BUG=708393
Review-Url: https://codereview.chromium.org/2804483002
Cr-Commit-Position: refs/heads/master@{#462348}
Committed: https://chromium.googlesource.com/chromium/src/+/dd3c9a967d856c4dc8b41fc1738caa4c035c6b82

[dominicc (has gone to gerrit), 2017-04-05 02:35:11]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 02:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2017-04-05 02:37:46]

dominicc@chromium.org changed reviewers:
+ scottmg@chromium.org

[dominicc (has gone to gerrit), 2017-04-05 02:37:47]

PTAL

Particularly roll.py which is the new thing here.

[commit-bot: I haz the power, 2017-04-05 02:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:44:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[dominicc (has gone to gerrit), 2017-04-05 03:55:49]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 03:56:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 04:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 04:04:19]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dominicc (has gone to gerrit), 2017-04-05 04:49:52]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 04:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 06:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 06:20:47]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2017-04-06 00:07:43]

dominicc@chromium.org changed reviewers:
+ ochang@chromium.org
- scottmg@chromium.org

[dominicc (has gone to gerrit), 2017-04-06 00:07:44]

PTAL

[Oliver Chang, 2017-04-06 01:09:24]

lgtm with some nits

https://codereview.chromium.org/2804483002/diff/20001/third_party/libxml/chro...
File third_party/libxml/chromium/roll.py (right):

https://codereview.chromium.org/2804483002/diff/20001/third_party/libxml/chro...
third_party/libxml/chromium/roll.py:73: patches = [
nit: maybe rename these global constants to uppercase?

https://codereview.chromium.org/2804483002/diff/20001/third_party/libxml/chro...
third_party/libxml/chromium/roll.py:113: xml_win32_configure_options = [
it seems a little difficult to me to make sure that the xml_configure_options
are kept in sync with the win32 one.

do you think it's worth doing something like:

xml_configure_options = [
   ('--with-icu', 'icu=yes'),
  ...
]

?

https://codereview.chromium.org/2804483002/diff/20001/third_party/libxml/chro...
third_party/libxml/chromium/roll.py:115: 
nit: extra newline?

https://codereview.chromium.org/2804483002/diff/20001/third_party/libxml/chro...
third_party/libxml/chromium/roll.py:330: files_to_remove = [
nit: maybe put this at the top with all the other constants?

[dominicc (has gone to gerrit), 2017-04-06 02:03:27]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2017-04-06 02:03:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org
Link to the patchset: https://codereview.chromium.org/2804483002/#ps30001
(title: "Code review feedback for the roll script.")

[commit-bot: I haz the power, 2017-04-06 02:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 03:49:23]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1491444207451950,
"parent_rev": "d138af58ead4b9965944f5cb7ed2a37cfed91617", "commit_rev":
"dd3c9a967d856c4dc8b41fc1738caa4c035c6b82"}

[commit-bot: I haz the power, 2017-04-06 03:50:06]

Description was changed from

==========
Check in the libxml roll script.

This rolls libxml to the same upstream point,
e905f08123e4a6e7731549e6f09dadff4cab65bd, but with these important
differences:

- The script which does the roll is included along with the roll
  itself.

- libxml2 src used to be patched with a mixture of sed, git
  cherry-pick, and patch. Now there is just a set of patch files in
  chromium/*.patch. This should make the delta to libxml2 more
  transparent. When a patch needs to be rebased, the changes to the
  patch file should be committed along with the roll.

- libxml2's features are now done with configure flags instead of
  editing the xmlversion.h headers.

- More unused files are deleted. This makes it clearer what may
  actually be built into Chromium.

BUG=708393
==========

to

==========
Check in the libxml roll script.

This rolls libxml to the same upstream point,
e905f08123e4a6e7731549e6f09dadff4cab65bd, but with these important
differences:

- The script which does the roll is included along with the roll
  itself.

- libxml2 src used to be patched with a mixture of sed, git
  cherry-pick, and patch. Now there is just a set of patch files in
  chromium/*.patch. This should make the delta to libxml2 more
  transparent. When a patch needs to be rebased, the changes to the
  patch file should be committed along with the roll.

- libxml2's features are now done with configure flags instead of
  editing the xmlversion.h headers.

- More unused files are deleted. This makes it clearer what may
  actually be built into Chromium.

BUG=708393

Review-Url: https://codereview.chromium.org/2804483002
Cr-Commit-Position: refs/heads/master@{#462348}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd3c9a967d856c4dc8b41fc1738c...
==========

[commit-bot: I haz the power, 2017-04-06 03:50:09]

Committed patchset #4 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/dd3c9a967d856c4dc8b41fc1738c...