Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: third_party/libxml/BUILD.gn

Issue 2804483002: Check in the libxml roll script. (Closed)
Patch Set: Code review feedback for the roll script. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libxml/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/BUILD.gn
diff --git a/third_party/libxml/BUILD.gn b/third_party/libxml/BUILD.gn
index 41c0fa716c4b44aa49cf0ad61aa123fa1c43d215..28ac4d034e65e6285dba25e8ceedb2f3a816bd9c 100644
--- a/third_party/libxml/BUILD.gn
+++ b/third_party/libxml/BUILD.gn
@@ -71,6 +71,8 @@ config("libxml_warnings") {
static_library("libxml") {
output_name = "libxml2"
+ # Commented out sources are libxml2 files we do not want to include. They are
+ # here to make it easy to identify files which are new.
sources = [
"chromium/libxml_utils.cc",
"chromium/libxml_utils.h",
@@ -162,8 +164,8 @@ static_library("libxml") {
#"src/trio.c",
#"src/trio.h",
#"src/triodef.h",
+ # Note: xpath.c #includes trionan.c
#"src/trionan.c",
- #"src/trionan.h",
#"src/triop.h",
#"src/triostr.c",
#"src/triostr.h",
« no previous file with comments | « no previous file | third_party/libxml/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698