Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2797923004: Improve XML serialization, URI parsing, and XPath node set processing. (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Oliver Chang
CC:
ail_google.com, chromium-reviews, dominicc+watchlist_chromium.org, nmehta_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve XML serialization, URI parsing, and XPath node set processing. BUG=705445, 700750, 708433, 708434 Review-Url: https://codereview.chromium.org/2797923004 Cr-Commit-Position: refs/heads/master@{#462404} Committed: https://chromium.googlesource.com/chromium/src/+/52bfd9b23ead461185b20736e216a73cad1864fe

Patch Set 1 #

Patch Set 2 : Refer to another bug. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -2 lines) Patch
M third_party/libxml/README.chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7375-xmlParsePEReference-xxe.patch View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/libxml/chromium/libxml2-2.9.4-security-CVE-2017-7376-nanohttp-out-of-bounds-write.patch View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/libxml/chromium/libxml2-2.9.4-security-xpath-nodetab-uaf.patch View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/libxml/chromium/libxml2-2.9.4-xmlDumpElementContent-null-deref.patch View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/libxml/chromium/roll.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libxml/src/parser.c View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/libxml/src/uri.c View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/libxml/src/valid.c View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/libxml/src/xpath.c View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
dominicc (has gone to gerrit)
This depends on https://codereview.chromium.org/2804483002 going first.
3 years, 8 months ago (2017-04-05 07:29:57 UTC) #3
Oliver Chang
lgtm
3 years, 8 months ago (2017-04-05 16:15:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797923004/40001
3 years, 8 months ago (2017-04-06 07:20:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/341655) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-06 07:26:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797923004/40001
3 years, 8 months ago (2017-04-06 08:40:28 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 09:50:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/52bfd9b23ead461185b20736e216...

Powered by Google App Engine
This is Rietveld 408576698