third_party/libxml/chromium/chromium-issue-620679.patch - Issue 2804483002: Check in the libxml roll script.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libxml/chromium/chromium-issue-620679.patch

Issue 2804483002: Check in the libxml roll script. (Closed)

Patch Set: Code review feedback for the roll script. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/libxml/src/parser.c b/third_party/libxml/src/parser.c

	2 index e3136123dca6..33786f08354d 100644

	3 --- a/parser.c

	4 +++ b/parser.c

	5 @@ -3426,8 +3426,15 @@ xmlParseNameComplex(xmlParserCtxtPtr ctxt) {

	6 xmlFatalErr(ctxt, XML_ERR_NAME_TOO_LONG, "Name");

	7 return(NULL);

	8 }

	9 - if ((*ctxt->input->cur == '\n') && (ctxt->input->cur[-1] == '\r'))

	10 + if ((*ctxt->input->cur == '\n') && (ctxt->input->cur[-1] == '\r')) {

	11 + if (ctxt->input->base > ctxt->input->cur - (len + 1)) {

	12 + return(NULL);

	13 + }

	14 return(xmlDictLookup(ctxt->dict, ctxt->input->cur - (len + 1), len));

	15 + }

	16 + if (ctxt->input->base > ctxt->input->cur - len) {

	17 + return(NULL);

	18 + }

	19 return(xmlDictLookup(ctxt->dict, ctxt->input->cur - len, len));

	20 }

	21

	22 --

	23 2.12.2.715.g7642488e1d-goog

	24

OLD	NEW