third_party/libxml/chromium/chromium-issue-599427.patch - Issue 2804483002: Check in the libxml roll script.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libxml/chromium/chromium-issue-599427.patch

Issue 2804483002: Check in the libxml roll script. (Closed)

Patch Set: Code review feedback for the roll script. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 --- a/xmlstring.c 2016-05-13 17:24:58.870079372 +0900

	2 +++ b/xmlstring.c 2016-04-25 13:58:09.879238595 +0900

	3 @@ -835,16 +835,20 @@

	4 while ( len-- > 0) {

	5 if ( !*ptr )

	6 break;

	7 - if ( (ch = *ptr++) & 0x80)

	8 - while ((ch<<=1) & 0x80 ) {

	9 - if (*ptr == 0) break;

	10 + if ( (ch = *ptr++) & 0x80) {

	11 + // Workaround for an optimization bug in VS 2015 Update 2, remove

	12 + // once the fix is released. crbug.com/599427

	13 + // https://connect.microsoft.com/VisualStudio/feedback/details/2582 138

	14 + xmlChar ch2 = ch;

	15 + while ((ch2<<=1) & 0x80 ) {

	16 ptr++;

	17 - }

	18 + if (*ptr == 0) break;

	19 + }

	20 + }

	21 }

	22 return (ptr - utf);

	23 }

	24

	25 -

	26 /**

	27 * xmlUTF8Strndup:

	28 * @utf: the input UTF8 *

OLD	NEW