Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655
Review-Url: https://codereview.chromium.org/2803073002
Cr-Original-Commit-Position: refs/heads/master@{#462904}
Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5
Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462958}
Committed: https://chromium.googlesource.com/chromium/src/+/36640ecf2e136c9d8d4dd1a4a25d9175129bb587

[hongchan, 2017-04-06 16:12:55]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-04-06 16:12:55]

PTAL. This is done manually.

[Raymond Toy, 2017-04-06 17:48:16]

lgtm

https://codereview.chromium.org/2803073002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/AudioArray.h (right):

https://codereview.chromium.org/2803073002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/AudioArray.h:87: CHECK(allocation);
Comment: This should have been done in the previous CL since it can be done
mechanically.

[hongchan, 2017-04-06 17:52:16]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-04-06 17:52:28]

https://codereview.chromium.org/2803073002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/AudioArray.h (right):

https://codereview.chromium.org/2803073002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/AudioArray.h:87: CHECK(allocation);
On 2017/04/06 17:48:16, Raymond Toy wrote:
> Comment: This should have been done in the previous CL since it can be done
> mechanically.

I didn't want to run a script only to take care of this single instance.

[commit-bot: I haz the power, 2017-04-06 17:53:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:25:05]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[hongchan, 2017-04-06 20:58:56]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 21:00:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 22:06:30]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[hongchan, 2017-04-07 15:24:39]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-04-07 15:24:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2803073002/#ps40001
(title: "Removing DCHECK_IS_ON to avoid compile error on ChromeOS bots")

[commit-bot: I haz the power, 2017-04-07 15:24:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:16:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491578679376740,
"parent_rev": "6fc9ec0f007de2e5f92a895ee83fb3c3ba2a475c", "commit_rev":
"f90cae07269c724f98ca3c196ea37ce7f6a801d5"}

[commit-bot: I haz the power, 2017-04-07 17:17:37]

Description was changed from

==========
Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655
==========

to

==========
Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655

Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462904}
Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...
==========

[commit-bot: I haz the power, 2017-04-07 17:17:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...

[hongchan, 2017-04-07 17:28:03]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2807593003/ by hongchan@chromium.org.

The reason for reverting is: Unexpected compilation error from buildbot Android
Builder..

[findit-for-me, 2017-04-07 17:36:44]

Findit confirmed this CL at revision 462904 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[hongchan, 2017-04-07 17:38:03]

Description was changed from

==========
Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655

Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462904}
Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...
==========

to

==========
Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655

Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462904}
Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...
==========

[hongchan, 2017-04-07 17:43:38]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-04-07 17:43:38]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2803073002/#ps60001
(title: "Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp")

[commit-bot: I haz the power, 2017-04-07 17:44:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:25:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491587018034840,
"parent_rev": "60d8d102bad145cb66565d6240b85c3115053d4d", "commit_rev":
"36640ecf2e136c9d8d4dd1a4a25d9175129bb587"}

[commit-bot: I haz the power, 2017-04-07 19:26:17]

Description was changed from

==========
Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655

Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462904}
Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...
==========

to

==========
Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG=707655

Review-Url: https://codereview.chromium.org/2803073002
Cr-Original-Commit-Position: refs/heads/master@{#462904}
Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...
Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462958}
Committed:
https://chromium.googlesource.com/chromium/src/+/36640ecf2e136c9d8d4dd1a4a25d...
==========

[commit-bot: I haz the power, 2017-04-07 19:26:18]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/36640ecf2e136c9d8d4dd1a4a25d...