third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp - Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)

Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/audio/SincResampler.cpp ('k') | third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp

diff --git a/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp b/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp

index 366e61424c0092684864ce8215878e0c17a4b695..9fc2c67648b3d8b802287239e97254826dcfab40 100644

--- a/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp

+++ b/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp

@@ -35,9 +35,7 @@

namespace blink {

-#if DCHECK_IS_ON()

const unsigned kMaxFFTPow2Size = 15;

-#endif

// Normal constructor: allocates for a given fftSize.

FFTFrame::FFTFrame(unsigned fftSize)

@@ -49,7 +47,7 @@ FFTFrame::FFTFrame(unsigned fftSize)

m_inverseContext(nullptr),

m_complexData(fftSize) {

// We only allow power of two.

- ASSERT(1UL << m_log2FFTSize == m_FFTSize);

+ DCHECK_EQ(1UL << m_log2FFTSize, m_FFTSize);

m_forwardContext = contextForSize(m_log2FFTSize);

m_inverseContext = contextForSize(m_log2FFTSize);

@@ -143,7 +141,7 @@ void FFTFrame::doInverseFFT(float* data) {

OMXFFTSpec_R_F32* FFTFrame::contextForSize(unsigned log2FFTSize) {

DCHECK(log2FFTSize);

- ASSERT(log2FFTSize <= kMaxFFTPow2Size);

+ DCHECK_LE(log2FFTSize, kMaxFFTPow2Size);

int bufSize;

OMXResult status = omxSP_FFTGetBufSize_R_F32(log2FFTSize, &bufSize);