third_party/WebKit/Source/platform/audio/DirectConvolver.cpp - Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/DirectConvolver.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)

Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/audio/DirectConvolver.cpp

diff --git a/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp b/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp

index 1cf4ce58d6cdd297ae5419809e584bea4a0c0bf6..3b2d84c50a4cd0c8ef10a49750da947b28e4ed79 100644

--- a/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp

+++ b/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp

@@ -50,13 +50,13 @@ void DirectConvolver::process(AudioFloatArray* convolutionKernel,

const float* sourceP,

float* destP,

size_t framesToProcess) {

- ASSERT(framesToProcess == m_inputBlockSize);

+ DCHECK_EQ(framesToProcess, m_inputBlockSize);

if (framesToProcess != m_inputBlockSize)

return;

// Only support kernelSize <= m_inputBlockSize

size_t kernelSize = convolutionKernel->size();

- ASSERT(kernelSize <= m_inputBlockSize);

+ DCHECK_LE(kernelSize, m_inputBlockSize);

if (kernelSize > m_inputBlockSize)

return;