Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)
Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
diff --git a/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp b/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
index 3cb346926a41c3e60b2bd09d1526ac19d0165ee6..3d1f3e78578a5e0cdac919dcd9f3db48d1c9ef18 100644
--- a/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
+++ b/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
@@ -61,7 +61,7 @@ ReverbConvolverStage::ReverbConvolverStage(
m_fftConvolver = WTF::makeUnique<FFTConvolver>(fftSize);
} else {
DCHECK(!stageOffset);
- ASSERT(stageLength <= fftSize / 2);
+ DCHECK_LE(stageLength, fftSize / 2);
m_directKernel = WTF::wrapUnique(new AudioFloatArray(fftSize / 2));
m_directKernel->copyToRange(impulseResponse, 0, stageLength);
@@ -77,7 +77,7 @@ ReverbConvolverStage::ReverbConvolverStage(
// this out...
size_t halfSize = fftSize / 2;
if (!m_directMode) {
- ASSERT(totalDelay >= halfSize);
+ DCHECK_GE(totalDelay, halfSize);
if (totalDelay >= halfSize)
totalDelay -= halfSize;
}
@@ -177,7 +177,7 @@ void ReverbConvolverStage::process(const float* source,
memcpy(preDelayedDestination, source, sizeof(float) * framesToProcess);
m_preReadWriteIndex += framesToProcess;
- ASSERT(m_preReadWriteIndex <= m_preDelayLength);
+ DCHECK_LE(m_preReadWriteIndex, m_preDelayLength);
if (m_preReadWriteIndex >= m_preDelayLength)
m_preReadWriteIndex = 0;
}

Powered by Google App Engine
This is Rietveld 408576698