Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)
Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
diff --git a/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp b/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
index 38d1da601f86bc78e229f940517e7e3623d4b19e..074a05a08bca5628eb3b94fe185d8e611b5bc0f5 100644
--- a/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
+++ b/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
@@ -51,7 +51,7 @@ DynamicsCompressor::DynamicsCompressor(float sampleRate,
}
void DynamicsCompressor::setParameterValue(unsigned parameterID, float value) {
- ASSERT(parameterID < ParamLast);
+ DCHECK_LT(parameterID, static_cast<unsigned>(ParamLast));
if (parameterID < ParamLast)
m_parameters[parameterID] = value;
}
@@ -84,7 +84,7 @@ void DynamicsCompressor::initializeParameters() {
}
float DynamicsCompressor::parameterValue(unsigned parameterID) {
- ASSERT(parameterID < ParamLast);
+ DCHECK_LT(parameterID, static_cast<unsigned>(ParamLast));
return m_parameters[parameterID];
}
@@ -100,7 +100,8 @@ void DynamicsCompressor::process(const AudioBus* sourceBus,
unsigned numberOfChannels = destinationBus->numberOfChannels();
unsigned numberOfSourceChannels = sourceBus->numberOfChannels();
- ASSERT(numberOfChannels == m_numberOfChannels && numberOfSourceChannels);
+ DCHECK_EQ(numberOfChannels, m_numberOfChannels);
+ DCHECK(numberOfSourceChannels);
if (numberOfChannels != m_numberOfChannels || !numberOfSourceChannels) {
destinationBus->zero();

Powered by Google App Engine
This is Rietveld 408576698