Update window.internals.addTextMatchMarker() to take enum instead of bool

Update window.internals.addTextMatchMarker() to take enum instead of bool

Suggested by @yosin here:
https://codereview.chromium.org/2801483002#msg20

We are changing DocumentMarkerController::addTextMatchMarker() to take an enum in https://codereview.chromium.org/2801483002 since it's unclear from looking at a callsite what "true" and "false" mean. This CL handles the window.internals changes separately since a bunch of tests have to be updated.

BUG=707867
Review-Url: https://codereview.chromium.org/2802543002
Cr-Commit-Position: refs/heads/master@{#462319}
Committed: https://chromium.googlesource.com/chromium/src/+/3ca300989422ff59471397342e4789fb659290cf

[rlanday, 2017-04-05 02:32:16]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-04-05 02:32:39]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-04-05 02:32:39]

rlanday@chromium.org changed required reviewers:
+ yosin@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:33:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 03:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 03:56:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-04-05 04:01:24]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-04-05 04:01:24]

lgtm for code change

Please update description as self explained with What, Why, Outcome, References
for renaming.
In this way, people doesn't need to read discussion in review.

[tkent, 2017-04-05 04:16:32]

https://codereview.chromium.org/2802543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2802543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.cpp:1009: if
(equalIgnoringCase(matchStatus, "Active"))
Please don't use equalIgnoringCase().  It's unnecessarily complex.  Use
equalIgnoringASCIICase().

[rlanday, 2017-04-05 18:03:40]

Description was changed from

==========
Update window.internals.addTextMatchMarker() to take enum instead of bool

Suggested by @yosin here:
https://codereview.chromium.org/2801483002#msg20

BUG=707867
==========

to

==========
Update window.internals.addTextMatchMarker() to take enum instead of bool

Suggested by @yosin here:
https://codereview.chromium.org/2801483002#msg20

We are changing DocumentMarkerController::addTextMatchMarker() to take an enum
in https://codereview.chromium.org/2801483002 since it's unclear from looking at
a callsite what "true" and "false" mean. This CL handles the window.internals
changes separately since a bunch of tests have to be updated.

BUG=707867
==========

[rlanday, 2017-04-05 19:08:05]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 19:08:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 20:23:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:23:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rlanday, 2017-04-05 20:51:55]

rlanday@chromium.org changed reviewers:
+ skobes@chromium.org

[rlanday, 2017-04-05 20:51:55]

rlanday@chromium.org changed required reviewers:
+ skobes@chromium.org
- yosin@chromium.org

[rlanday, 2017-04-05 20:53:08]

rlanday@chromium.org changed reviewers:
- skobes@chromium.org

[rlanday, 2017-04-05 20:53:08]

rlanday@chromium.org changed required reviewers:
+ tkent@chromium.org
- skobes@chromium.org

[rlanday, 2017-04-05 21:00:48]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 21:01:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-04-05 21:02:17]

On 2017/04/05 at 04:16:32, tkent wrote:
>
https://codereview.chromium.org/2802543002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/testing/Internals.cpp (right):
> 
>
https://codereview.chromium.org/2802543002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/testing/Internals.cpp:1009: if
(equalIgnoringCase(matchStatus, "Active"))
> Please don't use equalIgnoringCase().  It's unnecessarily complex.  Use
equalIgnoringASCIICase().

Updated

[tkent, 2017-04-05 21:44:19]

lgtm

[commit-bot: I haz the power, 2017-04-05 22:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:23:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-04-05 23:14:26]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-04-05 23:14:29]

On 2017/04/05 at 21:44:19, tkent wrote:
> lgtm

[rlanday, 2017-04-05 23:14:49]

I've added the k prefix here since we're adding it to the C++ enum in
https://codereview.chromium.org/2801483002

[commit-bot: I haz the power, 2017-04-05 23:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:51:29]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-04-06 01:46:57]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-06 01:46:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2802543002/#ps80001
(title: "Fix one more test, add k prefix")

[commit-bot: I haz the power, 2017-04-06 01:47:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 01:54:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491443217964030,
"parent_rev": "345ac542f1ee7737574e70ec508a5ecd13cd4006", "commit_rev":
"3ca300989422ff59471397342e4789fb659290cf"}

[commit-bot: I haz the power, 2017-04-06 01:55:07]

Description was changed from

==========
Update window.internals.addTextMatchMarker() to take enum instead of bool

Suggested by @yosin here:
https://codereview.chromium.org/2801483002#msg20

We are changing DocumentMarkerController::addTextMatchMarker() to take an enum
in https://codereview.chromium.org/2801483002 since it's unclear from looking at
a callsite what "true" and "false" mean. This CL handles the window.internals
changes separately since a bunch of tests have to be updated.

BUG=707867
==========

to

==========
Update window.internals.addTextMatchMarker() to take enum instead of bool

Suggested by @yosin here:
https://codereview.chromium.org/2801483002#msg20

We are changing DocumentMarkerController::addTextMatchMarker() to take an enum
in https://codereview.chromium.org/2801483002 since it's unclear from looking at
a callsite what "true" and "false" mean. This CL handles the window.internals
changes separately since a bunch of tests have to be updated.

BUG=707867

Review-Url: https://codereview.chromium.org/2802543002
Cr-Commit-Position: refs/heads/master@{#462319}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ca300989422ff59471397342e47...
==========

[commit-bot: I haz the power, 2017-04-06 01:55:08]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3ca300989422ff59471397342e47...