third_party/WebKit/LayoutTests/fast/dom/documentmarker-set-active.html - Issue 2802543002: Update window.internals.addTextMatchMarker() to take enum instead of bool

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/documentmarker-set-active.html

Issue 2802543002: Update window.internals.addTextMatchMarker() to take enum instead of bool (Closed)

Patch Set: Fix one more test, add k prefix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/documentmarker-add-adjacent-text.html ('k') | third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-hittest.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <body style="min-height: 5000px">	3 <body style="min-height: 5000px">

4 <span id="elt">text</span>	4 <span id="elt">text</span>

5	5

6 <script>	6 <script>

7 description('Checks that bounds are handled properly when activating TextMatch m arkers.');	7 description('Checks that bounds are handled properly when activating TextMatch m arkers.');

8	8

9 if (window.testRunner)	9 if (window.testRunner)

10 testRunner.dumpAsText();	10 testRunner.dumpAsText();

11	11

12 var range = document.createRange();	12 var range = document.createRange();

13 var elt = document.getElementById('elt').firstChild;	13 var elt = document.getElementById('elt').firstChild;

14 range.setStart(elt, 1);	14 range.setStart(elt, 1);

15 range.setEnd(elt, 3);	15 range.setEnd(elt, 3);

16	16

17 if (!window.internals) {	17 if (!window.internals) {

18 alert('This test requires window.interals to run!');	18 alert('This test requires window.interals to run!');

19 } else {	19 } else {

20 window.internals.addTextMatchMarker(range, false);	20 window.internals.addTextMatchMarker(range, 'kInactive');

21	21

22 window.internals.setMarkersActive(elt, 0, 1, true);	22 window.internals.setMarkersActive(elt, 0, 1, true);

23 shouldBe('window.internals.activeMarkerCountForNode(elt)', '0');	23 shouldBe('window.internals.activeMarkerCountForNode(elt)', '0');

24	24

25 window.internals.setMarkersActive(elt, 1, 2, true);	25 window.internals.setMarkersActive(elt, 1, 2, true);

26 shouldBe('window.internals.activeMarkerCountForNode(elt)', '1');	26 shouldBe('window.internals.activeMarkerCountForNode(elt)', '1');

27	27

28 window.internals.setMarkersActive(elt, 2, 3, false);	28 window.internals.setMarkersActive(elt, 2, 3, false);

29 shouldBe('window.internals.activeMarkerCountForNode(elt)', '0');	29 shouldBe('window.internals.activeMarkerCountForNode(elt)', '0');

30	30

31 window.internals.setMarkersActive(elt, 3, 4, true);	31 window.internals.setMarkersActive(elt, 3, 4, true);

32 shouldBe('window.internals.activeMarkerCountForNode(elt)', '0');	32 shouldBe('window.internals.activeMarkerCountForNode(elt)', '0');

33 }	33 }

34	34

35 var successfullyParsed = true;	35 var successfullyParsed = true;

36 </script>	36 </script>

37 </body>	37 </body>

38 </html>	38 </html>

OLD	NEW