third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html - Issue 2802543002: Update window.internals.addTextMatchMarker() to take enum instead of bool

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/text/text-match-highlights-big-line-height.html

Issue 2802543002: Update window.internals.addTextMatchMarker() to take enum instead of bool (Closed)

Patch Set: Fix one more test, add k prefix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/text-match-transparent-text.html ('k') | third_party/WebKit/LayoutTests/svg/custom/text-match-highlight.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 Text match highlight should not extend into the line spacing.	2 Text match highlight should not extend into the line spacing.

3 <div style="line-height: 30px; font-size: 15px">	3 <div style="line-height: 30px; font-size: 15px">

4 <br id='b1'>AAA	4 <br id='b1'>AAA

5 </div>	5 </div>

6	6

7 <div style="line-height: 30px; font-size: 15px; writing-mode: vertical-rl">	7 <div style="line-height: 30px; font-size: 15px; writing-mode: vertical-rl">

8 <br id='b2'>AAA	8 <br id='b2'>AAA

9 </div>	9 </div>

10	10

11 <script>	11 <script>

12 function highlightRange(element, start, end, active) {	12 function highlightRange(element, start, end, active) {

13 var range = document.createRange();	13 var range = document.createRange();

14 range.setStart(element, start);	14 range.setStart(element, start);

15 range.setEnd(element, end);	15 range.setEnd(element, end);

16 internals.addTextMatchMarker(range, active);	16 internals.addTextMatchMarker(range, active);

17 }	17 }

18	18

19 if (window.internals) {	19 if (window.internals) {

20 onload = function() {	20 onload = function() {

21 highlightRange(document.getElementById('b1').nextSibling, 0, 3, false);	21 highlightRange(document.getElementById('b1').nextSibling, 0, 3, 'kInactive') ;

22 highlightRange(document.getElementById('b2').nextSibling, 0, 3, true);	22 highlightRange(document.getElementById('b2').nextSibling, 0, 3, 'kActive');

23 internals.setMarkedTextMatchesAreHighlighted(document, true);	23 internals.setMarkedTextMatchesAreHighlighted(document, true);

24 };	24 };

25 }	25 }

26 </script>	26 </script>

OLD	NEW