third_party/WebKit/Source/core/testing/Internals.h - Issue 2802543002: Update window.internals.addTextMatchMarker() to take enum instead of bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.h

Issue 2802543002: Update window.internals.addTextMatchMarker() to take enum instead of bool (Closed)

Patch Set: Fix one more test, add k prefix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/Internals.h

diff --git a/third_party/WebKit/Source/core/testing/Internals.h b/third_party/WebKit/Source/core/testing/Internals.h

index dd0c161d86d56fa261f54136f2d62e80c231a4cc..660cdbd73279db93ff1f1bfaa2afb235ef52c066 100644

--- a/third_party/WebKit/Source/core/testing/Internals.h

+++ b/third_party/WebKit/Source/core/testing/Internals.h

@@ -183,7 +183,9 @@ class Internals final : public GarbageCollected<Internals>,

const String& markerType,

unsigned index,

ExceptionState&);

- void addTextMatchMarker(const Range*, bool isActive);

+ void addTextMatchMarker(const Range*,

+ const String& matchStatus,

+ ExceptionState&);

void addCompositionMarker(const Range*,

const String& underlineColorValue,

bool thick,