Update window.internals.addTextMatchMarker() to take enum instead of bool

third_party/WebKit/Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 986 matching lines @@
 String Internals::markerDescriptionForNode(Node* node,
                                            const String& markerType,
                                            unsigned index,
                                            ExceptionState& exceptionState) {
   DocumentMarker* marker = markerAt(node, markerType, index, exceptionState);
   if (!marker)
     return String();
   return marker->description();
 }
 
-void Internals::addTextMatchMarker(const Range* range, bool isActive) {
+static WTF::Optional<DocumentMarker::MatchStatus> matchStatusFrom(
+    const String& matchStatus) {
+  if (equalIgnoringCase(matchStatus, "Active"))

[tkent, 2017/04/05 04:16:32]

Please don't use equalIgnoringCase().  It's unnecessarily complex.  Use
equalIgnoringASCIICase().

+    return DocumentMarker::MatchStatus::Active;
+  if (equalIgnoringCase(matchStatus, "Inactive"))
+    return DocumentMarker::MatchStatus::Inactive;
+  return WTF::nullopt;
+}
+
+void Internals::addTextMatchMarker(const Range* range,
+                                   const String& matchStatus,
+                                   ExceptionState& exceptionState) {
   DCHECK(range);
   if (!range->ownerDocument().view())
     return;
 
+  WTF::Optional<DocumentMarker::MatchStatus> matchStatusEnum =
+      matchStatusFrom(matchStatus);
+  if (!matchStatusEnum) {
+    exceptionState.throwDOMException(
+        SyntaxError,
+        "The match status provided ('" + matchStatus + "') is invalid.");
+    return;
+  }
+
   range->ownerDocument().updateStyleAndLayoutIgnorePendingStylesheets();
-  range->ownerDocument().markers().addTextMatchMarker(
-      EphemeralRange(range), isActive ? DocumentMarker::MatchStatus::Active
-                                      : DocumentMarker::MatchStatus::Inactive);
+  range->ownerDocument().markers().addTextMatchMarker(EphemeralRange(range),
+                                                      matchStatusEnum.value());
 
   // This simulates what the production code does after
   // DocumentMarkerController::addTextMatchMarker().
   range->ownerDocument().view()->invalidatePaintForTickmarks();
 }
 
 static bool parseColor(const String& value,
                        Color& color,
                        ExceptionState& exceptionState,
                        String errorMessage) {
@@ skipping 2195 matching lines @@
 
 void Internals::crash() {
   CHECK(false) << "Intentional crash";
 }
 
 void Internals::setIsLowEndDevice(bool isLowEndDevice) {
   MemoryCoordinator::setIsLowEndDeviceForTesting(isLowEndDevice);
 }
 
 }  // namespace blink