Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2799883003: Switch from TestBrowserThread to TestBrowserThreadBundle in chrome. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, sky
CC:
chromium-reviews, msramek+watch_chromium.org, oshima+watch_chromium.org, tzik, tburkard+watch_chromium.org, chfremer+watch_chromium.org, browser-components-watch_chromium.org, markusheintz_, timvolodine, jdonnelly+watch_chromium.org, cbentzel+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, raymes+watch_chromium.org, net-reviews_chromium.org, rlp+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, extensions-reviews_chromium.org, nhiroki, dkrahn+watch_chromium.org, feature-media-reviews_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org, gcasto+watchlist_chromium.org, David Trainor- moved to gerrit, gavinp+prer_chromium.org, Lei Zhang, tfarina, mcasas+geolocation_chromium.org, tommycli, mac-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch from TestBrowserThread to TestBrowserThreadBundle in chrome. TestBrowserThread is deprecated. TestBrowserThreadBundle provides all browser threads, a blocking pool and a TaskScheduler. This CL was generated using the script posted on the bug + git cl format + tools/sort-headers.py + some manual adjustments. BUG=272091 R=gab@chromium.org TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2799883003 Cr-Commit-Position: refs/heads/master@{#467670} Committed: https://chromium.googlesource.com/chromium/src/+/2ce6dc221fcc30ce679d5e85e926e6fca853281e

Patch Set 1 #

Patch Set 2 : self-review and rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix-build-error #

Patch Set 6 : fix-build-error #

Patch Set 7 : fix-build-error #

Total comments: 6

Patch Set 8 : add-newlines #

Patch Set 9 : fix-string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -527 lines) Patch
M chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/attestation/attestation_policy_observer_unittest.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl_unittest.cc View 1 2 3 4 5 6 7 8 5 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/component_updater/component_installers_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/content_settings_usages_state_unittest.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings_factory_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 2 5 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 1 2 3 4 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/download/download_shelf_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/download/download_status_updater_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/download/notification/download_item_notification_unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 2 5 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/extensions/chrome_info_map_unittest.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/extensions/default_apps_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/pack_extension_unittest.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/geolocation/geolocation_settings_state_unittest.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service_unittest.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/media/webrtc/webrtc_log_util_unittest.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_android_unittest.cc View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 2 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 1 2 3 4 32 chunks +35 lines, -61 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 1 2 3 4 5 6 25 chunks +31 lines, -56 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 5 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common_unittest.cc View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle_unittest.cc View 1 2 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 2 5 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/printing/cloud_print/gcd_api_flow_unittest.cc View 1 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 1 2 3 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 6 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_unittest.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 1 2 3 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model_unittest.cc View 1 2 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/ui/chrome_select_file_policy_unittest.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source_unittest.cc View 1 2 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/theme_source_unittest.cc View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 48 (40 generated)
fdoray
3 years, 8 months ago (2017-04-06 13:12:09 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to owners.
3 years, 8 months ago (2017-04-06 13:12:12 UTC) #3
fdoray
gab@: PTAL
3 years, 8 months ago (2017-04-24 12:30:55 UTC) #31
gab
Awesome! lgtm w/ nits https://codereview.chromium.org/2799883003/diff/120001/chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc File chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc (right): https://codereview.chromium.org/2799883003/diff/120001/chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc#newcode5 chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc:5: #include "chrome/browser/chromeos/attestation/attestation_ca_client.h" include fixer should ...
3 years, 7 months ago (2017-04-25 14:53:15 UTC) #32
fdoray
https://codereview.chromium.org/2799883003/diff/120001/chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc File chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc (right): https://codereview.chromium.org/2799883003/diff/120001/chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc#newcode5 chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc:5: #include "chrome/browser/chromeos/attestation/attestation_ca_client.h" On 2017/04/25 14:53:15, gab wrote: > include ...
3 years, 7 months ago (2017-04-27 13:12:26 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799883003/140001
3 years, 7 months ago (2017-04-27 13:13:07 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/414051)
3 years, 7 months ago (2017-04-27 13:49:31 UTC) #40
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 14:40:01 UTC) #48
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/2ce6dc221fcc30ce679d5e85e926...

Powered by Google App Engine
This is Rietveld 408576698