Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: chrome/browser/extensions/standard_management_policy_provider_unittest.cc

Issue 2799883003: Switch from TestBrowserThread to TestBrowserThreadBundle in chrome. (Closed)
Patch Set: fix-string Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/standard_management_policy_provider.h" 5 #include "chrome/browser/extensions/standard_management_policy_provider.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/threading/thread_task_runner_handle.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/browser/extensions/blacklist.h" 12 #include "chrome/browser/extensions/blacklist.h"
13 #include "chrome/browser/extensions/extension_management.h" 13 #include "chrome/browser/extensions/extension_management.h"
14 #include "chrome/browser/extensions/test_extension_prefs.h" 14 #include "chrome/browser/extensions/test_extension_prefs.h"
15 #include "content/public/test/test_browser_thread.h" 15 #include "content/public/test/test_browser_thread_bundle.h"
16 #include "extensions/browser/extension_prefs.h" 16 #include "extensions/browser/extension_prefs.h"
17 #include "extensions/common/manifest_constants.h" 17 #include "extensions/common/manifest_constants.h"
18 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
19 19
20 namespace extensions { 20 namespace extensions {
21 21
22 class StandardManagementPolicyProviderTest : public testing::Test { 22 class StandardManagementPolicyProviderTest : public testing::Test {
23 public: 23 public:
24 StandardManagementPolicyProviderTest() 24 StandardManagementPolicyProviderTest()
25 : ui_thread_(content::BrowserThread::UI, &message_loop_), 25 : prefs_(base::ThreadTaskRunnerHandle::Get()),
26 file_thread_(content::BrowserThread::FILE, &message_loop_),
27 prefs_(message_loop_.task_runner().get()),
28 settings_(new ExtensionManagement(prefs()->pref_service(), false)), 26 settings_(new ExtensionManagement(prefs()->pref_service(), false)),
29 provider_(settings_.get()) {} 27 provider_(settings_.get()) {}
30 28
31 protected: 29 protected:
32 ExtensionPrefs* prefs() { 30 ExtensionPrefs* prefs() {
33 return prefs_.prefs(); 31 return prefs_.prefs();
34 } 32 }
35 33
36 scoped_refptr<const Extension> CreateExtension(Manifest::Location location, 34 scoped_refptr<const Extension> CreateExtension(Manifest::Location location,
37 bool required) { 35 bool required) {
38 base::DictionaryValue values; 36 base::DictionaryValue values;
39 values.SetString(manifest_keys::kName, "test"); 37 values.SetString(manifest_keys::kName, "test");
40 values.SetString(manifest_keys::kVersion, "0.1"); 38 values.SetString(manifest_keys::kVersion, "0.1");
41 std::string error; 39 std::string error;
42 scoped_refptr<const Extension> extension = Extension::Create( 40 scoped_refptr<const Extension> extension = Extension::Create(
43 base::FilePath(), location, values, Extension::NO_FLAGS, &error); 41 base::FilePath(), location, values, Extension::NO_FLAGS, &error);
44 CHECK(extension.get()) << error; 42 CHECK(extension.get()) << error;
45 return extension; 43 return extension;
46 } 44 }
47 45
48 base::MessageLoop message_loop_; 46 content::TestBrowserThreadBundle test_browser_thread_bundle_;
49 content::TestBrowserThread ui_thread_;
50 content::TestBrowserThread file_thread_;
51 47
52 TestExtensionPrefs prefs_; 48 TestExtensionPrefs prefs_;
53 std::unique_ptr<ExtensionManagement> settings_; 49 std::unique_ptr<ExtensionManagement> settings_;
54 50
55 StandardManagementPolicyProvider provider_; 51 StandardManagementPolicyProvider provider_;
56 }; 52 };
57 53
58 // Tests the behavior of the ManagementPolicy provider methods for an 54 // Tests the behavior of the ManagementPolicy provider methods for an
59 // extension required by policy. 55 // extension required by policy.
60 TEST_F(StandardManagementPolicyProviderTest, RequiredExtension) { 56 TEST_F(StandardManagementPolicyProviderTest, RequiredExtension) {
(...skipping 21 matching lines...) Expand all
82 base::string16 error16; 78 base::string16 error16;
83 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), &error16)); 79 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), &error16));
84 EXPECT_EQ(base::string16(), error16); 80 EXPECT_EQ(base::string16(), error16);
85 EXPECT_TRUE(provider_.UserMayModifySettings(extension.get(), &error16)); 81 EXPECT_TRUE(provider_.UserMayModifySettings(extension.get(), &error16));
86 EXPECT_EQ(base::string16(), error16); 82 EXPECT_EQ(base::string16(), error16);
87 EXPECT_FALSE(provider_.MustRemainEnabled(extension.get(), &error16)); 83 EXPECT_FALSE(provider_.MustRemainEnabled(extension.get(), &error16));
88 EXPECT_EQ(base::string16(), error16); 84 EXPECT_EQ(base::string16(), error16);
89 } 85 }
90 86
91 } // namespace extensions 87 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698