Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 2799883003: Switch from TestBrowserThread to TestBrowserThreadBundle in chrome. (Closed)
Patch Set: fix-string Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc
diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
index 150d509b885e2a710abc199c8633e8cfbd7467d8..c5394c578699e575e810395ed52f7f2dbe01e36c 100644
--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
@@ -11,11 +11,9 @@
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "components/prefs/testing_pref_service.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
-using content::BrowserThread;
-
class FakeExternalProtocolHandlerWorker
: public shell_integration::DefaultProtocolClientWorker {
public:
@@ -113,11 +111,10 @@ class FakeExternalProtocolHandlerDelegate
class ExternalProtocolHandlerTest : public testing::Test {
protected:
ExternalProtocolHandlerTest()
- : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
- file_thread_(BrowserThread::FILE) {}
+ : test_browser_thread_bundle_(
+ content::TestBrowserThreadBundle::REAL_FILE_THREAD) {}
void SetUp() override {
- file_thread_.Start();
local_state_.reset(new TestingPrefServiceSimple);
profile_.reset(new TestingProfile());
chrome::RegisterLocalState(local_state_->registry());
@@ -153,9 +150,7 @@ class ExternalProtocolHandlerTest : public testing::Test {
ASSERT_EQ(should_block, delegate_.has_blocked());
}
- base::MessageLoopForUI ui_message_loop_;
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_thread_;
+ content::TestBrowserThreadBundle test_browser_thread_bundle_;
FakeExternalProtocolHandlerDelegate delegate_;

Powered by Google App Engine
This is Rietveld 408576698