chrome/browser/download/notification/download_item_notification_unittest.cc - Issue 2799883003: Switch from TestBrowserThread to TestBrowserThreadBundle in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_item_notification_unittest.cc

Issue 2799883003: Switch from TestBrowserThread to TestBrowserThreadBundle in chrome. (Closed)

Patch Set: fix-string Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_status_updater_unittest.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_item_notification_unittest.cc

diff --git a/chrome/browser/download/notification/download_item_notification_unittest.cc b/chrome/browser/download/notification/download_item_notification_unittest.cc

index c95b8455b93f0ec60bab4a0897e0addea2f99535..b3de43856836ca148799257b518cbbb85aed47c5 100644

--- a/chrome/browser/download/notification/download_item_notification_unittest.cc

+++ b/chrome/browser/download/notification/download_item_notification_unittest.cc

@@ -8,7 +8,6 @@

#include <utility>

#include "base/macros.h"

-#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

#include "base/test/test_simple_task_runner.h"

#include "base/threading/thread_task_runner_handle.h"

@@ -20,7 +19,7 @@

#include "chrome/test/base/testing_profile_manager.h"

#include "content/public/test/mock_download_item.h"

#include "content/public/test/mock_download_manager.h"

-#include "content/public/test/test_browser_thread.h"

+#include "content/public/test/test_browser_thread_bundle.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/message_center/fake_message_center.h"

@@ -61,9 +60,7 @@ class MockMessageCenter : public message_center::FakeMessageCenter {

class DownloadItemNotificationTest : public testing::Test {

public:

- DownloadItemNotificationTest()

- : ui_thread_(content::BrowserThread::UI, &message_loop_),

- profile_(nullptr) {}

+ DownloadItemNotificationTest() : profile_(nullptr) {}

void SetUp() override {

testing::Test::SetUp();

@@ -168,8 +165,7 @@ class DownloadItemNotificationTest : public testing::Test {

download_item_notification_->notification_.get());

}

- base::MessageLoopForUI message_loop_;

- content::TestBrowserThread ui_thread_;

+ content::TestBrowserThreadBundle test_browser_thread_bundle_;

std::unique_ptr<TestingProfileManager> profile_manager_;

Profile* profile_;