Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3887)

Unified Diff: chrome/browser/ui/webui/theme_source_unittest.cc

Issue 2799883003: Switch from TestBrowserThread to TestBrowserThreadBundle in chrome. (Closed)
Patch Set: fix-string Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/fileicon_source_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/theme_source_unittest.cc
diff --git a/chrome/browser/ui/webui/theme_source_unittest.cc b/chrome/browser/ui/webui/theme_source_unittest.cc
index 045a93dd8218e55c9b117641a97f42802369c044..1fe1c490c212a3cea6539d2a2f1d510a45c09522 100644
--- a/chrome/browser/ui/webui/theme_source_unittest.cc
+++ b/chrome/browser/ui/webui/theme_source_unittest.cc
@@ -13,16 +13,12 @@
#include "chrome/common/url_constants.h"
#include "chrome/grit/theme_resources.h"
#include "chrome/test/base/testing_profile.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
-using content::BrowserThread;
-
class WebUISourcesTest : public testing::Test {
public:
- WebUISourcesTest()
- : result_data_size_(0),
- ui_thread_(BrowserThread::UI, base::MessageLoop::current()) {}
+ WebUISourcesTest() : result_data_size_(0) {}
TestingProfile* profile() const { return profile_.get(); }
ThemeSource* theme_source() const { return theme_source_.get(); }
@@ -56,8 +52,7 @@ class WebUISourcesTest : public testing::Test {
content::URLDataSource::GotDataCallback callback_;
- base::MessageLoop loop_;
- content::TestBrowserThread ui_thread_;
+ content::TestBrowserThreadBundle test_browser_thread_bundle_;
std::unique_ptr<TestingProfile> profile_;
std::unique_ptr<ThemeSource> theme_source_;
@@ -82,8 +77,6 @@ TEST_F(WebUISourcesTest, ThemeSourceImages) {
}
TEST_F(WebUISourcesTest, ThemeSourceCSS) {
- content::TestBrowserThread io_thread(BrowserThread::IO,
- base::MessageLoop::current());
// Generating the test data for the NTP CSS would just involve copying the
// method, or being super brittle and hard-coding the result (requiring
// an update to the unittest every time the CSS template changes), so we
« no previous file with comments | « chrome/browser/ui/webui/fileicon_source_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698