Use SignalingAddress in SignalStrategy insterface.

Use SignalingAddress in SignalStrategy insterface.

Previously SignalStrategy::GetLocalJid() was returning non-normalized
JID. The value was passed as is to the authenticator in
JingleSessionManager::OnSignalStrategyIncomingStanza(). Client used
normalized JID value from SignalingAddress for authentication. As 
result authentication was failing for hosts that use mixed-case
accounts. With this change GetLocalJid() is replaced with
GetLocalAddress(), which allows to ensure that JID is normalized on
both ends of connection.

BUG=707833
Review-Url: https://codereview.chromium.org/2798393007
Cr-Commit-Position: refs/heads/master@{#463737}
Committed: https://chromium.googlesource.com/chromium/src/+/9fe3bc8107285979782a49dbcf0a37cfe0187696

[Sergey Ulanov, 2017-04-07 23:05:54]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2017-04-07 23:10:25]

Description was changed from

==========
Use SignalingAddress in SignalStrategy insterface.
==========

to

==========
Use SignalingAddress in SignalStrategy insterface.

Previously SignalStrategy::GetLocalJid() was returning non-normalized
JID. The value was passed as is to the authenticator in
JingleSessionManager::OnSignalStrategyIncomingStanza(). Client used
normalized JID value from SignalingAddress for authentication. As 
result authentication was failing for hosts that use mixed-case
accounts. With this change GetLocalJid() is replaced with
GetLocalAddress(), which allows to ensure that JID is normalized on
both ends of connection.

BUG=707833
==========

[Sergey Ulanov, 2017-04-07 23:10:25]

sergeyu@chromium.org changed reviewers:
+ joedow@chromium.org, kelvinp@chromium.org

[joedow, 2017-04-10 16:46:42]

lgtm

https://codereview.chromium.org/2798393007/diff/20001/remoting/protocol/jingl...
File remoting/protocol/jingle_session_unittest.cc (right):

https://codereview.chromium.org/2798393007/diff/20001/remoting/protocol/jingl...
remoting/protocol/jingle_session_unittest.cc:55: const char kHostJid[] =
"host@gmail.com/123";
Do we already have unit tests for mixed case JIDs at the appropriate level in
the stack?

[Sergey Ulanov, 2017-04-10 19:58:03]

https://codereview.chromium.org/2798393007/diff/20001/remoting/protocol/jingl...
File remoting/protocol/jingle_session_unittest.cc (right):

https://codereview.chromium.org/2798393007/diff/20001/remoting/protocol/jingl...
remoting/protocol/jingle_session_unittest.cc:55: const char kHostJid[] =
"host@gmail.com/123";
On 2017/04/10 16:46:42, joedow wrote:
> Do we already have unit tests for mixed case JIDs at the appropriate level in
> the stack?

We have unittests, but they use FakeAuthenticator, which doesn't verify that the
same peer identities are passed on the both ends, so these tests didn't catch
this issue. I'll fix this in a separate CL.

[Sergey Ulanov, 2017-04-11 17:54:36]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-04-11 17:54:36]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2798393007/#ps40001
(title: "\sync")

[commit-bot: I haz the power, 2017-04-11 17:55:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 18:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:18:23]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sergey Ulanov, 2017-04-11 18:44:28]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-04-11 18:44:29]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2798393007/#ps60001
(title: "header")

[commit-bot: I haz the power, 2017-04-11 18:45:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:57:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491936268762520,
"parent_rev": "ac532e0f3a6f6d70c9ce10b4258f6f610617246a", "commit_rev":
"9fe3bc8107285979782a49dbcf0a37cfe0187696"}

[commit-bot: I haz the power, 2017-04-11 19:58:11]

Description was changed from

==========
Use SignalingAddress in SignalStrategy insterface.

Previously SignalStrategy::GetLocalJid() was returning non-normalized
JID. The value was passed as is to the authenticator in
JingleSessionManager::OnSignalStrategyIncomingStanza(). Client used
normalized JID value from SignalingAddress for authentication. As 
result authentication was failing for hosts that use mixed-case
accounts. With this change GetLocalJid() is replaced with
GetLocalAddress(), which allows to ensure that JID is normalized on
both ends of connection.

BUG=707833
==========

to

==========
Use SignalingAddress in SignalStrategy insterface.

Previously SignalStrategy::GetLocalJid() was returning non-normalized
JID. The value was passed as is to the authenticator in
JingleSessionManager::OnSignalStrategyIncomingStanza(). Client used
normalized JID value from SignalingAddress for authentication. As 
result authentication was failing for hosts that use mixed-case
accounts. With this change GetLocalJid() is replaced with
GetLocalAddress(), which allows to ensure that JID is normalized on
both ends of connection.

BUG=707833

Review-Url: https://codereview.chromium.org/2798393007
Cr-Commit-Position: refs/heads/master@{#463737}
Committed:
https://chromium.googlesource.com/chromium/src/+/9fe3bc8107285979782a49dbcf0a...
==========

[commit-bot: I haz the power, 2017-04-11 19:58:14]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9fe3bc8107285979782a49dbcf0a...