Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: remoting/signaling/log_to_server_unittest.cc

Issue 2798393007: Use SignalingAddress in SignalStrategy insterface. (Closed)
Patch Set: header Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/iq_sender_unittest.cc ('k') | remoting/signaling/mock_signal_strategy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/log_to_server_unittest.cc
diff --git a/remoting/signaling/log_to_server_unittest.cc b/remoting/signaling/log_to_server_unittest.cc
index 772a33e143272989d0a7b6323e213224bc773ac6..856f69c1ffa6a9dbcad5a0f818bbeeed326100a7 100644
--- a/remoting/signaling/log_to_server_unittest.cc
+++ b/remoting/signaling/log_to_server_unittest.cc
@@ -8,6 +8,7 @@
#include "base/run_loop.h"
#include "remoting/signaling/mock_signal_strategy.h"
#include "remoting/signaling/server_log_entry_unittest.h"
+#include "remoting/signaling/signaling_address.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -38,7 +39,7 @@ MATCHER_P2(IsLogEntry, key, value, "") {
class LogToServerTest : public testing::Test {
public:
- LogToServerTest() {}
+ LogToServerTest() : signal_strategy_(SignalingAddress(kClientJid)) {}
void SetUp() override {
EXPECT_CALL(signal_strategy_, AddListener(_));
EXPECT_CALL(signal_strategy_, RemoveListener(_));
@@ -56,8 +57,6 @@ class LogToServerTest : public testing::Test {
TEST_F(LogToServerTest, LogWhenConnected) {
{
InSequence s;
- EXPECT_CALL(signal_strategy_, GetLocalJid())
- .WillRepeatedly(Return(kClientJid));
EXPECT_CALL(signal_strategy_, AddListener(_));
EXPECT_CALL(signal_strategy_, GetNextId());
EXPECT_CALL(signal_strategy_, SendStanzaPtr(IsLogEntry("a", "1")))
@@ -80,8 +79,6 @@ TEST_F(LogToServerTest, LogWhenConnected) {
}
TEST_F(LogToServerTest, DontLogWhenDisconnected) {
- EXPECT_CALL(signal_strategy_, GetLocalJid())
- .WillRepeatedly(Return(kClientJid));
EXPECT_CALL(signal_strategy_, SendStanzaPtr(_)).Times(0);
ServerLogEntry entry;
« no previous file with comments | « remoting/signaling/iq_sender_unittest.cc ('k') | remoting/signaling/mock_signal_strategy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698