Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2805173005: Move SignalingAddress to remoting/signaling (Closed)

Created:
3 years, 8 months ago by Sergey Ulanov
Modified:
3 years, 8 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SignalingAddress to remoting/signaling This will allow to use SignalingAddress in SignalStrategy, which is necessary to ensure that JIDs are normalized consistenly. BUG=707833 Review-Url: https://codereview.chromium.org/2805173005 Cr-Commit-Position: refs/heads/master@{#463517} Committed: https://chromium.googlesource.com/chromium/src/+/4cb31957c3d99982c42bdad33cdccd97e6709021

Patch Set 1 #

Patch Set 2 : unittests #

Patch Set 3 : . #

Patch Set 4 : fmt #

Patch Set 5 : fix compilation on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -230 lines) Patch
M remoting/protocol/jingle_messages.h View 2 chunks +1 line, -36 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 2 6 chunks +12 lines, -146 lines 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 1 2 3 2 chunks +20 lines, -48 lines 0 comments Download
M remoting/signaling/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A remoting/signaling/signaling_address.h View 1 chunk +59 lines, -0 lines 0 comments Download
A remoting/signaling/signaling_address.cc View 1 2 3 4 1 chunk +162 lines, -0 lines 0 comments Download
A remoting/signaling/signaling_address_unittest.cc View 1 2 3 1 chunk +191 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
Sergey Ulanov
3 years, 8 months ago (2017-04-07 22:04:44 UTC) #2
kelvinp
On 2017/04/07 22:04:44, Sergey Ulanov wrote: lgtm. Please move the unittests from jingle_messages_unittest.cc (ParseAddress/IgnoreInvalidAddress) into ...
3 years, 8 months ago (2017-04-10 16:41:08 UTC) #3
Sergey Ulanov
On 2017/04/10 16:41:08, kelvinp wrote: > On 2017/04/07 22:04:44, Sergey Ulanov wrote: > > lgtm. ...
3 years, 8 months ago (2017-04-10 18:42:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805173005/40001
3 years, 8 months ago (2017-04-10 19:55:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/401986)
3 years, 8 months ago (2017-04-10 20:35:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805173005/60001
3 years, 8 months ago (2017-04-10 23:31:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/386135)
3 years, 8 months ago (2017-04-11 00:17:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805173005/80001
3 years, 8 months ago (2017-04-11 00:47:10 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 03:26:26 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4cb31957c3d99982c42bdad33cdc...

Powered by Google App Engine
This is Rietveld 408576698