Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: remoting/signaling/push_notification_subscriber_unittest.cc

Issue 2798393007: Use SignalingAddress in SignalStrategy insterface. (Closed)
Patch Set: header Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/push_notification_subscriber.cc ('k') | remoting/signaling/signal_strategy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/push_notification_subscriber_unittest.cc
diff --git a/remoting/signaling/push_notification_subscriber_unittest.cc b/remoting/signaling/push_notification_subscriber_unittest.cc
index 6536f9c6c3d459b6ff5f3ca353eff4a8c5b2ba4c..a7ef2edd81221395998024a1966b8575507314a8 100644
--- a/remoting/signaling/push_notification_subscriber_unittest.cc
+++ b/remoting/signaling/push_notification_subscriber_unittest.cc
@@ -5,6 +5,7 @@
#include "remoting/signaling/push_notification_subscriber.h"
#include "remoting/signaling/mock_signal_strategy.h"
+#include "remoting/signaling/signaling_address.h"
#include "testing/gmock/include/gmock/gmock.h"
using testing::_;
@@ -16,7 +17,7 @@ using testing::SaveArg;
namespace remoting {
TEST(PushNotificationSubscriberTest, Create) {
- MockSignalStrategy signal_strategy;
+ MockSignalStrategy signal_strategy(SignalingAddress("user@domain/resource"));
EXPECT_CALL(signal_strategy, AddListener(_));
EXPECT_CALL(signal_strategy, RemoveListener(_));
@@ -25,9 +26,7 @@ TEST(PushNotificationSubscriberTest, Create) {
}
TEST(PushNotificationSubscriberTest, Subscribe) {
- MockSignalStrategy signal_strategy;
- EXPECT_CALL(signal_strategy, GetLocalJid())
- .WillRepeatedly(Return("user@domain/resource"));
+ MockSignalStrategy signal_strategy(SignalingAddress("user@domain/resource"));
EXPECT_CALL(signal_strategy, GetNextId()).WillOnce(Return("next_id"));
EXPECT_CALL(signal_strategy, AddListener(_)).Times(AtLeast(1));
EXPECT_CALL(signal_strategy, RemoveListener(_)).Times(AtLeast(1));
« no previous file with comments | « remoting/signaling/push_notification_subscriber.cc ('k') | remoting/signaling/signal_strategy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698