Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3635)

Issue 2808283002: Improve tests for Mixed-Case JIDs. (Closed)

Created:
3 years, 4 months ago by Sergey Ulanov
Modified:
3 years, 4 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve tests for Mixed-Case JIDs. 1. FakeAuthenticator now verifies that correct IDs are passed on both ends of the connection. 2. All tests in JingleSessionTest now use mixed-case JIDs. BUG=707833 Review-Url: https://codereview.chromium.org/2808283002 Cr-Commit-Position: refs/heads/master@{#463833} Committed: https://chromium.googlesource.com/chromium/src/+/65aaa85ee5c1ff86742d9a426348afc7be78568e

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -159 lines) Patch
M remoting/protocol/fake_authenticator.h View 1 2 3 4 chunks +24 lines, -10 lines 0 comments Download
M remoting/protocol/fake_authenticator.cc View 1 2 3 7 chunks +40 lines, -21 lines 0 comments Download
M remoting/protocol/fake_session.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/protocol/ice_transport_unittest.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 2 19 chunks +89 lines, -114 lines 0 comments Download
M remoting/protocol/webrtc_transport_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
Sergey Ulanov
3 years, 4 months ago (2017-04-11 00:47:43 UTC) #3
joedow
lgtm https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_authenticator.h File remoting/protocol/fake_authenticator.h (right): https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_authenticator.h#newcode130 remoting/protocol/fake_authenticator.h:130: FakeAuthenticator::Config config); nit: Config struct passed by const ...
3 years, 4 months ago (2017-04-11 16:20:34 UTC) #4
Sergey Ulanov
https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_authenticator.h File remoting/protocol/fake_authenticator.h (right): https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_authenticator.h#newcode130 remoting/protocol/fake_authenticator.h:130: FakeAuthenticator::Config config); On 2017/04/11 16:20:34, joedow wrote: > nit: ...
3 years, 4 months ago (2017-04-11 21:14:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808283002/40001
3 years, 4 months ago (2017-04-11 21:15:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/428417) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 4 months ago (2017-04-11 21:33:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808283002/60001
3 years, 4 months ago (2017-04-11 22:38:14 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-04-11 23:27:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/65aaa85ee5c1ff86742d9a426348...

Powered by Google App Engine
This is Rietveld 408576698