[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020
Review-Url: https://codereview.chromium.org/2797923006
Cr-Original-Commit-Position: refs/heads/master@{#44536}
Committed: https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe355551bea3
Review-Url: https://codereview.chromium.org/2797923006
Cr-Commit-Position: refs/heads/master@{#44540}
Committed: https://chromium.googlesource.com/v8/v8/+/5f7e633113d4230613a893b482eae7707c543fa7

[bbudge, 2017-04-06 00:44:56]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 00:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-04-06 00:56:44]

bbudge@chromium.org changed reviewers:
+ bmeurer@chromium.org, martyn.capewell@arm.com

[bbudge, 2017-04-06 00:56:45]

martyn for ARM
benedikt for test OWNERS

[commit-bot: I haz the power, 2017-04-06 01:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 01:12:44]

Dry run: This issue passed the CQ dry run.

[martyn.capewell, 2017-04-06 13:09:50]

https://codereview.chromium.org/2797923006/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2797923006/diff/1/src/arm/assembler-arm.cc#ne...
src/arm/assembler-arm.cc:4740: if (reg_type == NEON_Q) {
This idiom may become common if more D/Q operations are implemented, as the
instruction encodings often differ only on Q bit and register code split.
Perhaps add a local split_code variant that accepts the reg_type?

https://codereview.chromium.org/2797923006/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

https://codereview.chromium.org/2797923006/diff/1/src/arm/simulator-arm.cc#ne...
src/arm/simulator-arm.cc:5093: case Neon8: {
It would be good to factorise the zip and uzp operations into two functions
templated on the element type and register, so you can write something like this
for zip:

int s = sizeof(R) / (2 * sizeof(E));
for (int i = 0; i < s; i++) {
  dst1[i * 2] = src1[i];
  dst1[i * 2 + 1] = src2[i];
  dst2[i * 2] = src1[i + s];
  dst2[i * 2 + 1] = src1[i + s];
}

[bbudge, 2017-04-06 17:44:12]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:44:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-04-06 17:49:43]

https://codereview.chromium.org/2797923006/diff/1/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):

https://codereview.chromium.org/2797923006/diff/1/src/arm/assembler-arm.cc#ne...
src/arm/assembler-arm.cc:4740: if (reg_type == NEON_Q) {
On 2017/04/06 13:09:49, martyn.capewell wrote:
> This idiom may become common if more D/Q operations are implemented, as the
> instruction encodings often differ only on Q bit and register code split.
> Perhaps add a local split_code variant that accepts the reg_type?

Done.

https://codereview.chromium.org/2797923006/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

https://codereview.chromium.org/2797923006/diff/1/src/arm/simulator-arm.cc#ne...
src/arm/simulator-arm.cc:5093: case Neon8: {
On 2017/04/06 13:09:49, martyn.capewell wrote:
> It would be good to factorise the zip and uzp operations into two functions
> templated on the element type and register, so you can write something like
this
> for zip:
> 
> int s = sizeof(R) / (2 * sizeof(E));
> for (int i = 0; i < s; i++) {
>   dst1[i * 2] = src1[i];
>   dst1[i * 2 + 1] = src2[i];
>   dst2[i * 2] = src1[i + s];
>   dst2[i * 2 + 1] = src1[i + s];
> }

Done.

I rewrote the get_ and set_q_register templates to accept a size, so more of the
repetitive code could be templatized, then templatized as many existing
functions in the simulator as made sense, including the vzip, vuzp, and vtrn
operations.

The new methods are get_ and set_neon_register.

[commit-bot: I haz the power, 2017-04-06 17:50:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 17:50:47]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[bbudge, 2017-04-06 18:29:16]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 18:29:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:53:35]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-04-09 18:47:28]

This is ready - PTAL.

[martyn.capewell, 2017-04-10 10:05:06]

Those new accessors tidy things up nicely.

lgtm

[Benedikt Meurer, 2017-04-10 10:28:33]

LGTM (rubber-stamped)

[bbudge, 2017-04-10 17:33:46]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-04-10 17:33:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, martyn.capewell@arm.com
Link to the patchset: https://codereview.chromium.org/2797923006/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-04-10 17:34:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:56:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491845626939390,
"parent_rev": "df0eaff48dd4eaae6072f3434bca23420fcfc2f1", "commit_rev":
"6588187ae3acaa5b40762c539ee9fe355551bea3"}

[commit-bot: I haz the power, 2017-04-10 17:56:52]

Description was changed from

==========
[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020
==========

to

==========
[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2797923006
Cr-Commit-Position: refs/heads/master@{#44536}
Committed:
https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe35555...
==========

[commit-bot: I haz the power, 2017-04-10 17:56:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe35555...

[bbudge, 2017-04-10 19:59:59]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2810703003/ by bbudge@chromium.org.

The reason for reverting is: Breaks:
http://builders/V8%20Arm%20-%20debug/builds/2751.

[bbudge, 2017-04-10 21:00:46]

Description was changed from

==========
[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2797923006
Cr-Commit-Position: refs/heads/master@{#44536}
Committed:
https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe35555...
==========

to

==========
[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2797923006
Cr-Commit-Position: refs/heads/master@{#44536}
Committed:
https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe35555...
==========

[bbudge, 2017-04-10 21:02:02]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 21:02:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 21:25:30]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-04-10 21:39:26]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-04-10 21:39:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, martyn.capewell@arm.com
Link to the patchset: https://codereview.chromium.org/2797923006/#ps80001
(title: "Remove tests for vzip.32 / vuzp.32 - these are pseudo ops for
vtrn.32.")

[commit-bot: I haz the power, 2017-04-10 21:39:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:41:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491860366825000,
"parent_rev": "41b228057f89e73fbaae867177d523e60d4e92bc", "commit_rev":
"5f7e633113d4230613a893b482eae7707c543fa7"}

[commit-bot: I haz the power, 2017-04-10 21:41:09]

Description was changed from

==========
[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2797923006
Cr-Commit-Position: refs/heads/master@{#44536}
Committed:
https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe35555...
==========

to

==========
[ARM] Implement D-register versions of vzip, vuzp, and vtrn.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2797923006
Cr-Original-Commit-Position: refs/heads/master@{#44536}
Committed:
https://chromium.googlesource.com/v8/v8/+/6588187ae3acaa5b40762c539ee9fe35555...
Review-Url: https://codereview.chromium.org/2797923006
Cr-Commit-Position: refs/heads/master@{#44540}
Committed:
https://chromium.googlesource.com/v8/v8/+/5f7e633113d4230613a893b482eae7707c5...
==========

[commit-bot: I haz the power, 2017-04-10 21:41:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/5f7e633113d4230613a893b482eae7707c5...