[Payments] Don't record CanMakePayment when in incognito mode.

[Payments] Don't record CanMakePayment when in incognito mode.

BUG=704689
Review-Url: https://codereview.chromium.org/2790253002
Cr-Commit-Position: refs/heads/master@{#461746}
Committed: https://chromium.googlesource.com/chromium/src/+/5d388daecd1805d661cd65f43f2c1418aefa35a9

[sebsg, 2017-04-03 19:58:02]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-04-03 19:58:03]

Hi Math, PTAL?

[Mathieu, 2017-04-03 20:19:31]

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger.cc:159: // metrics.
*metric

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger.h:19: class JourneyLogger {
a clearer API, in my opinion, is to have the JourneyLogger constructed with
is_incognito as an argument. That way no one forgets to set it.

[sebsg, 2017-04-03 21:04:26]

Another look?

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger.cc (right):

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger.cc:159: // metrics.
On 2017/04/03 20:19:30, Mathieu wrote:
> *metric

There are more than one :)

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2790253002/diff/1/components/payments/core/jo...
components/payments/core/journey_logger.h:19: class JourneyLogger {
On 2017/04/03 20:19:31, Mathieu wrote:
> a clearer API, in my opinion, is to have the JourneyLogger constructed with
> is_incognito as an argument. That way no one forgets to set it.

Done.

[Mathieu, 2017-04-03 21:05:54]

lgtm with nit

https://codereview.chromium.org/2790253002/diff/20001/components/payments/con...
File components/payments/content/android/journey_logger_android.cc (right):

https://codereview.chromium.org/2790253002/diff/20001/components/payments/con...
components/payments/content/android/journey_logger_android.cc:100: jboolean
jisIncognito) {
jis_incognito

[sebsg, 2017-04-03 21:14:15]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-04-03 21:15:00]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2017-04-03 21:15:01]

Hi Rouslan, PTAL?

[commit-bot: I haz the power, 2017-04-03 21:15:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 22:35:06]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-04-04 15:27:36]

LGTM % comments

https://codereview.chromium.org/2790253002/diff/40001/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2790253002/diff/40001/components/payments/con...
components/payments/content/android/journey_logger_android.h:22:
JourneyLoggerAndroid(bool is_incognito);
explicit

https://codereview.chromium.org/2790253002/diff/40001/components/payments/cor...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2790253002/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:56: JourneyLogger(bool is_incognito);
explicit

https://codereview.chromium.org/2790253002/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:115: // Records the metrics related
the the CanMakePayment method, if the Payment
"unless in incognito mode" feels more succinct than "if the Payment REquest was
not done in an incognito tab."

[sebsg, 2017-04-04 15:50:38]

Thanks, sending to CQ.

https://codereview.chromium.org/2790253002/diff/40001/components/payments/con...
File components/payments/content/android/journey_logger_android.h (right):

https://codereview.chromium.org/2790253002/diff/40001/components/payments/con...
components/payments/content/android/journey_logger_android.h:22:
JourneyLoggerAndroid(bool is_incognito);
On 2017/04/04 15:27:35, ಠ_ಠ wrote:
> explicit

Done.

https://codereview.chromium.org/2790253002/diff/40001/components/payments/cor...
File components/payments/core/journey_logger.h (right):

https://codereview.chromium.org/2790253002/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:56: JourneyLogger(bool is_incognito);
On 2017/04/04 15:27:35, ಠ_ಠ wrote:
> explicit

Done.

https://codereview.chromium.org/2790253002/diff/40001/components/payments/cor...
components/payments/core/journey_logger.h:115: // Records the metrics related
the the CanMakePayment method, if the Payment
On 2017/04/04 15:27:35, ಠ_ಠ wrote:
> "unless in incognito mode" feels more succinct than "if the Payment REquest
was
> not done in an incognito tab."

Done.

[sebsg, 2017-04-04 15:50:42]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-04-04 15:50:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2790253002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-04 15:51:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:42:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491321042684530,
"parent_rev": "08376b4003fdea077ec6df37f88305a65751101c", "commit_rev":
"5d388daecd1805d661cd65f43f2c1418aefa35a9"}

[commit-bot: I haz the power, 2017-04-04 16:43:55]

Description was changed from

==========
[Payments] Don't record CanMakePayment when in incognito mode.

BUG=704689
==========

to

==========
[Payments] Don't record CanMakePayment when in incognito mode.

BUG=704689

Review-Url: https://codereview.chromium.org/2790253002
Cr-Commit-Position: refs/heads/master@{#461746}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d388daecd1805d661cd65f43f2c...
==========

[commit-bot: I haz the power, 2017-04-04 16:43:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5d388daecd1805d661cd65f43f2c...