chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2790253002: [Payments] Don't record CanMakePayment when in incognito mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2790253002: [Payments] Don't record CanMakePayment when in incognito mode. (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerUnitTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 74283028cd88bbb5220504d018cfb630956454f3..41176e4dd1e0c7b4d18e7d55d359b8799b9a0ba1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -259,7 +259,7 @@ public class PaymentRequestImpl

private final byte[][] mCertificateChain;

private final AddressEditor mAddressEditor;

private final CardEditor mCardEditor;

- private final JourneyLogger mJourneyLogger = new JourneyLogger();

+ private final JourneyLogger mJourneyLogger;

private final boolean mIsIncognito;

private PaymentRequestClient mClient;

@@ -381,6 +381,8 @@ public class PaymentRequestImpl

mIsIncognito = activity != null && activity.getCurrentTabModel() != null

&& activity.getCurrentTabModel().isIncognito();

+ mJourneyLogger = new JourneyLogger(mIsIncognito);

if (sCanMakePaymentQueries == null) sCanMakePaymentQueries = new ArrayMap<>();

recordSuccessFunnelHistograms("Initiated");