[Payments] Don't record CanMakePayment when in incognito mode.

components/payments/core/journey_logger.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/core/journey_logger.h"
 
 #include <algorithm>
 
 #include "base/metrics/histogram_functions.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 39 matching lines @@
 
   DCHECK(!name_suffix.empty());
   return name_suffix;
 }
 
 }  // namespace
 
 JourneyLogger::JourneyLogger()
     : was_can_make_payments_used_(false),
       could_make_payment_(false),
-      was_show_called_(false) {}
+      was_show_called_(false),
+      is_incognito_(false) {}
 
 JourneyLogger::~JourneyLogger() {}
 
 void JourneyLogger::IncrementSelectionAdds(Section section) {
   DCHECK_LT(section, SECTION_MAX);
   sections_[section].number_selection_adds_++;
 }
 
 void JourneyLogger::IncrementSelectionChanges(Section section) {
   DCHECK_LT(section, SECTION_MAX);
@@ skipping 13 matching lines @@
 
 void JourneyLogger::SetCanMakePaymentValue(bool value) {
   was_can_make_payments_used_ = true;
   could_make_payment_ |= value;
 }
 
 void JourneyLogger::SetShowCalled() {
   was_show_called_ = true;
 }
 
+void JourneyLogger::SetIsIncognito() {
+  is_incognito_ = true;
+}
+
 void JourneyLogger::RecordJourneyStatsHistograms(
     CompletionStatus completion_status) {
   RecordSectionSpecificStats(completion_status);
 
   // Record the CanMakePayment metrics based on whether the transaction was
   // completed or aborted by the user (UserAborted) or otherwise (OtherAborted).
   RecordCanMakePaymentStats(completion_status);
 }
 
 void JourneyLogger::RecordSectionSpecificStats(
@@ skipping 39 matching lines @@
   } else {
     base::UmaHistogramEnumeration(
         "PaymentRequest.UserDidNotHaveSuggestionsForEverything."
         "EffectOnCompletion",
         completion_status, COMPLETION_STATUS_MAX);
   }
 }
 
 void JourneyLogger::RecordCanMakePaymentStats(
     CompletionStatus completion_status) {
+  // CanMakePayment always returns true in incognito mode. Don't log the
+  // metrics.

[Mathieu, 2017/04/03 20:19:30]

*metric

[sebsg, 2017/04/03 21:04:26]

There are more than one :)

+  if (is_incognito_)
+    return;
+
   // Record CanMakePayment usage.
   UMA_HISTOGRAM_ENUMERATION("PaymentRequest.CanMakePayment.Usage",
                             was_can_make_payments_used_
                                 ? CAN_MAKE_PAYMENT_USED
                                 : CAN_MAKE_PAYMENT_NOT_USED,
                             CAN_MAKE_PAYMENT_USE_MAX);
 
   RecordCanMakePaymentEffectOnShow();
   RecordCanMakePaymentEffectOnCompletion(completion_status);
 }
@@ skipping 24 matching lines @@
     histogram_name += "Used.TrueWithShowEffectOnCompletion";
   } else {
     histogram_name += "Used.FalseWithShowEffectOnCompletion";
   }
 
   base::UmaHistogramEnumeration(histogram_name, completion_status,
                                 COMPLETION_STATUS_MAX);
 }
 
 }  // namespace payments