[Payments] Don't record CanMakePayment when in incognito mode.

components/payments/core/journey_logger.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PAYMENTS_CORE_JOURNEY_LOGGER_H_
 #define COMPONENTS_PAYMENTS_CORE_JOURNEY_LOGGER_H_
 
 #include <string>
 
 #include "base/macros.h"
 
 namespace payments {
 
 // A class to keep track of different stats during a Payment Request journey. It
 // collects different metrics during the course of the checkout flow, like the
 // number of credit cards that the user added or edited. The metrics will be
 // logged when RecordJourneyStatsHistograms is called with the completion status
 // of the Payment Request.
 class JourneyLogger {

[Mathieu, 2017/04/03 20:19:31]

a clearer API, in my opinion, is to have the JourneyLogger constructed with
is_incognito as an argument. That way no one forgets to set it.

[sebsg, 2017/04/03 21:04:26]

Done.

  public:
   // Note: These constants should always be in sync with their counterpart in
   // components/payments/content/android/java/src/org/chromium/components/
   // payments/JourneyLogger.java.
   // The different sections of a Payment Request. Used to record journey
   // stats.
   enum Section {
     SECTION_CONTACT_INFO = 0,
     SECTION_CREDIT_CARDS = 1,
     SECTION_SHIPPING_ADDRESS = 2,
@@ skipping 38 matching lines @@
   // Sets the number of suggestions shown for the specified section.
   void SetNumberOfSuggestionsShown(Section section, int number);
 
   // Records the fact that the merchant called CanMakePayment and records it's
   // return value.
   void SetCanMakePaymentValue(bool value);
 
   // Records the fact that the Payment Request was shown to the user.
   void SetShowCalled();
 
+  // Records the fact that the Payment Request was done in an incognito tab.
+  void SetIsIncognito();
+
   // Records the histograms for all the sections that were requested by the
   // merchant and for the usage of the CanMakePayment method and its effect on
   // the transaction. This method should be called when the Payment Request has
   // either been completed or aborted.
   void RecordJourneyStatsHistograms(CompletionStatus completion_status);
 
  private:
   static const int NUMBER_OF_SECTIONS = 3;
 
   // Note: These constants should always be in sync with their counterpart in
@@ skipping 17 matching lines @@
     int number_selection_changes_;
     int number_selection_edits_;
     int number_suggestions_shown_;
     bool is_requested_;
   };
 
   // Records the histograms for all the sections that were requested by the
   // merchant.
   void RecordSectionSpecificStats(CompletionStatus completion_status);
 
-  // Records the metrics related the the CanMakePayment method.
+  // Records the metrics related the the CanMakePayment method, if the Payment
+  // Request was not done in an incognito tab.
   void RecordCanMakePaymentStats(CompletionStatus completion_status);
 
   // Records CanMakePayment's return value effect on whether the Payment Request
   // was shown or not.
   void RecordCanMakePaymentEffectOnShow();
 
   // Records the completion status depending on the the usage and return value
   // of the CanMakePaymentMethod.
   void RecordCanMakePaymentEffectOnCompletion(
       CompletionStatus completion_status);
 
   SectionStats sections_[NUMBER_OF_SECTIONS];
   bool was_can_make_payments_used_;
   bool could_make_payment_;
   bool was_show_called_;
+  bool is_incognito_;
 
   DISALLOW_COPY_AND_ASSIGN(JourneyLogger);
 };
 
 }  // namespace payments
 
 #endif  // COMPONENTS_PAYMENTS_CORE_JOURNEY_LOGGER_H_