[Payments] Don't record CanMakePayment when in incognito mode.

components/payments/core/journey_logger.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PAYMENTS_CORE_JOURNEY_LOGGER_H_
 #define COMPONENTS_PAYMENTS_CORE_JOURNEY_LOGGER_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 35 matching lines @@
     COMPLETION_STATUS_MAX,
   };
 
   // Used to mesure the impact of the CanMakePayment return value on whether the
   // Payment Request is shown to the user.
   static const int CMP_SHOW_COULD_NOT_MAKE_PAYMENT_AND_DID_NOT_SHOW = 0;
   static const int CMP_SHOW_DID_SHOW = 1 << 0;
   static const int CMP_SHOW_COULD_MAKE_PAYMENT_ = 1 << 1;
   static const int CMP_SHOW_MAX = 4;
 
-  JourneyLogger();
+  JourneyLogger(bool is_incognito);

[please use gerrit instead, 2017/04/04 15:27:35]

explicit

[sebsg, 2017/04/04 15:50:37]

Done.

   ~JourneyLogger();
 
   // Increments the number of selection adds for the specified section.
   void IncrementSelectionAdds(Section section);
 
   // Increments the number of selection changes for the specified section.
   void IncrementSelectionChanges(Section section);
 
   // Increments the number of selection edits for the specified section.
   void IncrementSelectionEdits(Section section);
@@ skipping 38 matching lines @@
     int number_selection_changes_;
     int number_selection_edits_;
     int number_suggestions_shown_;
     bool is_requested_;
   };
 
   // Records the histograms for all the sections that were requested by the
   // merchant.
   void RecordSectionSpecificStats(CompletionStatus completion_status);
 
-  // Records the metrics related the the CanMakePayment method.
+  // Records the metrics related the the CanMakePayment method, if the Payment

[please use gerrit instead, 2017/04/04 15:27:35]

"unless in incognito mode" feels more succinct than "if the Payment REquest was
not done in an incognito tab."

[sebsg, 2017/04/04 15:50:37]

Done.

+  // Request was not done in an incognito tab.
   void RecordCanMakePaymentStats(CompletionStatus completion_status);
 
   // Records CanMakePayment's return value effect on whether the Payment Request
   // was shown or not.
   void RecordCanMakePaymentEffectOnShow();
 
   // Records the completion status depending on the the usage and return value
   // of the CanMakePaymentMethod.
   void RecordCanMakePaymentEffectOnCompletion(
       CompletionStatus completion_status);
 
   SectionStats sections_[NUMBER_OF_SECTIONS];
   bool was_can_make_payments_used_;
   bool could_make_payment_;
   bool was_show_called_;
+  bool is_incognito_;
 
   DISALLOW_COPY_AND_ASSIGN(JourneyLogger);
 };
 
 }  // namespace payments
 
 #endif  // COMPONENTS_PAYMENTS_CORE_JOURNEY_LOGGER_H_