Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 278963002: add localmatrix parameter to shader's asNewEffect (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
Dominik Grewe, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add localmatrix parameter to shader's asNewEffect BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -38 lines) Patch
M include/core/SkShader.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +9 lines, -1 line 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M src/core/SkPictureShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 4 chunks +10 lines, -4 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 6 chunks +14 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
6 years, 7 months ago (2014-05-09 19:43:37 UTC) #1
bsalomon
lgtm
6 years, 7 months ago (2014-05-09 20:07:22 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-09 20:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/278963002/1
6 years, 7 months ago (2014-05-09 20:21:22 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 20:28:23 UTC) #5
Message was sent while issue was closed. 
Change committed as 14686

Powered by Google App Engine
This is Rietveld 408576698