Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2787673002: Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to one… (Closed)

Created:
3 years, 8 months ago by Pete Williamson
Modified:
3 years, 8 months ago
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to ones that still are relevant. BUG=706876 Review-Url: https://codereview.chromium.org/2787673002 Cr-Commit-Position: refs/heads/master@{#461785} Committed: https://chromium.googlesource.com/chromium/src/+/cdc4f6db65b451fb50f71c92fd04a24b07b520a3

Patch Set 1 #

Messages

Total messages: 23 (13 generated)
Pete Williamson
Cleaning up TODOs for background offlining.
3 years, 8 months ago (2017-03-29 23:10:55 UTC) #2
romax
LGTM, but i guess you still need an OWNER :)
3 years, 8 months ago (2017-03-30 01:27:05 UTC) #5
chili
lgtm but i'm neither committer nor owner :D
3 years, 8 months ago (2017-03-30 06:01:03 UTC) #8
fgorski
lgtm mod the fact that you don't have a bug number (you can find one ...
3 years, 8 months ago (2017-03-30 16:11:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787673002/1
3 years, 8 months ago (2017-03-30 17:39:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398871)
3 years, 8 months ago (2017-03-30 17:48:16 UTC) #15
Pete Williamson
+dtrainor for OWNERS review of change to ChromeBackgroundService.java (removed old comment)
3 years, 8 months ago (2017-03-30 18:00:47 UTC) #17
David Trainor- moved to gerrit
ChromeBackgroundService.java lgtm
3 years, 8 months ago (2017-04-03 17:55:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787673002/1
3 years, 8 months ago (2017-04-04 17:45:09 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 18:44:10 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdc4f6db65b451fb50f71c92fd04...

Powered by Google App Engine
This is Rietveld 408576698