Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: components/offline_pages/core/background/pick_request_task.cc

Issue 2787673002: Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to one… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/pick_request_task.cc
diff --git a/components/offline_pages/core/background/pick_request_task.cc b/components/offline_pages/core/background/pick_request_task.cc
index 516b09947006278963bd09ad5b93df6de135d6ee..1064987dc23087ada66b7161eb1e73353a1377fc 100644
--- a/components/offline_pages/core/background/pick_request_task.cc
+++ b/components/offline_pages/core/background/pick_request_task.cc
@@ -84,7 +84,6 @@ void PickRequestTask::Choose(
else
comparator = &PickRequestTask::RecencyFirstCompareFunction;
- // TODO(petewil): Consider replacing this bool with a better named enum.
bool non_user_requested_tasks_remaining = false;
bool cleanup_needed = false;
@@ -198,9 +197,7 @@ bool PickRequestTask::RequestConditionsSatisfied(
return false;
// If this request is not active yet, return false.
- // TODO(petewil): If the only reason we return nothing to do is that we have
- // inactive requests, we still want to try again later after their activation
- // time elapses, we shouldn't take ourselves completely off the scheduler.
+ // TODO(petewil): Remove the concept of activation time. crbug.com/705103.
if (request->activation_time() > base::Time::Now())
return false;
« no previous file with comments | « components/offline_pages/core/background/offliner_policy.h ('k') | components/offline_pages/core/background/reconcile_task.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698