Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/offline_pages/core/background/request_coordinator.cc

Issue 2787673002: Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to one… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/core/background/reconcile_task.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/core/background/request_coordinator.cc
diff --git a/components/offline_pages/core/background/request_coordinator.cc b/components/offline_pages/core/background/request_coordinator.cc
index 8060d6af4ab0678672c381b76ee821aabf821870..da13974b49661f5ee45ed6400cf4e7819cb38518 100644
--- a/components/offline_pages/core/background/request_coordinator.cc
+++ b/components/offline_pages/core/background/request_coordinator.cc
@@ -706,9 +706,6 @@ void RequestCoordinator::TryNextRequest(bool is_start_of_processing) {
// If this is the first call, the device conditions are current, no need to
// update them.
- // TODO(petewil): Now that we can get conditions any time, consider getting
- // them now instead of passing them in earlier when we start scheduled
- // processing.
if (!is_start_of_processing) {
// Get current device conditions from the Java side across the bridge.
// NetworkChangeNotifier will not have the right conditions if chromium is
@@ -745,7 +742,6 @@ void RequestCoordinator::TryNextRequest(bool is_start_of_processing) {
RequestConnectedEventForStarting();
// Let the scheduler know we are done processing.
- // TODO: Make sure the scheduler callback is valid before running it.
scheduler_callback_.Run(true);
DVLOG(2) << " out of time, giving up. " << __func__;
@@ -763,10 +759,6 @@ void RequestCoordinator::TryNextRequest(bool is_start_of_processing) {
base::Bind(&RequestCoordinator::RequestCounts,
weak_ptr_factory_.GetWeakPtr(), is_start_of_processing),
*current_conditions_.get(), disabled_requests_, prioritized_requests_);
- // TODO(petewil): Verify current_conditions has a good value on all calling
- // paths. It is really more of a "last known conditions" than "current
- // conditions". Consider having a call to Java to check the current
- // conditions.
}
// Called by the request picker when a request has been picked.
« no previous file with comments | « components/offline_pages/core/background/reconcile_task.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698