Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: components/offline_pages/core/background/cleanup_task.cc

Issue 2787673002: Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to one… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/cleanup_task.cc
diff --git a/components/offline_pages/core/background/cleanup_task.cc b/components/offline_pages/core/background/cleanup_task.cc
index 84e2a7864d4c24f9c466899da980bcd411166657..d66d48b610e7094ee977206906a587441e534170 100644
--- a/components/offline_pages/core/background/cleanup_task.cc
+++ b/components/offline_pages/core/background/cleanup_task.cc
@@ -56,8 +56,8 @@ void CleanupTask::Prune(
return;
}
- // TODO(petewil): Add UMA saying why we remove them
- // TODO(petewil): Round trip the reason for deleting through the RQ
+ // TODO(petewil): Add UMA saying why we remove them. Round trip the reason
+ // for deleting through the RQ callbacks. crbug.com/705115.
store_->RemoveRequests(expired_request_ids,
base::Bind(&CleanupTask::OnRequestsExpired,
weak_ptr_factory_.GetWeakPtr()));

Powered by Google App Engine
This is Rietveld 408576698