components/offline_pages/core/background/reconcile_task.cc - Issue 2787673002: Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to one…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/reconcile_task.cc

Issue 2787673002: Cleanup old TODO comments, removing ones that are no longer relevant, and adding bug numbers to one… (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/core/background/reconcile_task.cc

diff --git a/components/offline_pages/core/background/reconcile_task.cc b/components/offline_pages/core/background/reconcile_task.cc

index 9b8427530b565ebabf23a3e6f07d7ec5f43e3fd9..66833e859e4e9056cfee56c7e11b0634b2c60ece 100644

--- a/components/offline_pages/core/background/reconcile_task.cc

+++ b/components/offline_pages/core/background/reconcile_task.cc

@@ -48,8 +48,6 @@ void ReconcileTask::Reconcile(

if (request->request_state() == SavePageRequest::RequestState::OFFLINING) {

request->set_request_state(SavePageRequest::RequestState::AVAILABLE);

items_to_update.push_back(*request.get());

- // TODO(petewil): Consider adding UMA to see how often chrome gets killed

- // while processing a request.

}