Split Gradient impl into separate classes

Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into separate, private
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(), spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.

BUG=614368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2785203002
Cr-Commit-Position: refs/heads/master@{#461207}
Committed: https://chromium.googlesource.com/chromium/src/+/fb6b69556d51265620cc759174e77484fc6c6067

[f(malita), 2017-03-30 15:38:06]

Description was changed from

==========
Split Gradient impl into subclasses

WIP

BUG=
==========

to

==========
Split Gradient impl into subclasses

WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2017-03-30 15:38:13]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 15:38:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:00:02]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[f(malita), 2017-03-30 16:28:23]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:28:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-30 16:39:02]

Description was changed from

==========
Split Gradient impl into subclasses

WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate
subclasses.

Remove unused getters: p0(), p1(), startRadius(), endRadius(), spreadMethod().

Refactor isRadial() as a type getter.

Relocate isZeroSize() to CanvasGradient (its only client).


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2017-03-30 16:41:02]

Description was changed from

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate
subclasses.

Remove unused getters: p0(), p1(), startRadius(), endRadius(), spreadMethod().

Refactor isRadial() as a type getter.

Relocate isZeroSize() to CanvasGradient (its only client).


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2017-03-30 16:52:42]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:52:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-30 16:54:16]

Description was changed from

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate, private
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2017-03-30 16:55:53]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:56:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-30 17:49:14]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2017-03-30 18:10:04]

fmalita@chromium.org changed reviewers:
+ fs@opera.com, junov@chromium.org, schenney@chromium.org

[f(malita), 2017-03-30 20:37:13]

Description was changed from

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate, private
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate, private
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.

BUG=614368

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2017-03-30 21:31:52]

LGTM (% modules/canvas2d/ which I don't own.)

https://codereview.chromium.org/2785203002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Gradient.h (right):

https://codereview.chromium.org/2785203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Gradient.h:76: virtual ~Gradient() =
default;
Nit: Could you move this to the cpp-file (==out-of-line)? (Assuming it is
non-trivial because there's at least one ref-counted member.)

[f(malita), 2017-03-31 13:38:54]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 13:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-31 13:39:23]

https://codereview.chromium.org/2785203002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Gradient.h (right):

https://codereview.chromium.org/2785203002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Gradient.h:76: virtual ~Gradient() =
default;
On 2017/03/30 21:31:52, fs wrote:
> Nit: Could you move this to the cpp-file (==out-of-line)? (Assuming it is
> non-trivial because there's at least one ref-counted member.)

Done.

[commit-bot: I haz the power, 2017-03-31 16:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:04:11]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-03-31 17:07:52]

fmalita@chromium.org changed reviewers:
+ senorblanco@chromium.org

[f(malita), 2017-03-31 17:07:53]

junov/senorblanco: PTAL at the C2D bits.  Thanks!

[Stephen White, 2017-03-31 19:46:38]

Looks great. Awesome that you removed the duplicated data (p0, p1, etc) from the
Gradient class.

LGTM (but please wait for Justin to take a look too.)

[Justin Novosad, 2017-03-31 20:15:04]

Me likes.

lgtm

[f(malita), 2017-03-31 20:17:10]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-03-31 20:17:11]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2785203002/#ps80001
(title: "review")

[commit-bot: I haz the power, 2017-03-31 20:17:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 20:23:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490991430526330,
"parent_rev": "c9e97492256bb59a123fd0ba980afb5990784690", "commit_rev":
"fb6b69556d51265620cc759174e77484fc6c6067"}

[commit-bot: I haz the power, 2017-03-31 20:24:12]

Description was changed from

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate, private
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.

BUG=614368

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Split Gradient impl into separate classes

In preparation of adding a new gradient type (conic), refactor Gradient into
separate, private
subclasses.

 * more specific factory names: createLinear(), createRadial()

 * remove unused getters: p0(), p1(), startRadius(), endRadius(),
spreadMethod().

 * refactor isRadial() as a type getter.

 * relocate isZeroSize() to CanvasGradient (its only client).


Refactor-only, no functional changes.

BUG=614368

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2785203002
Cr-Commit-Position: refs/heads/master@{#461207}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb6b69556d51265620cc759174e7...
==========

[commit-bot: I haz the power, 2017-03-31 20:24:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fb6b69556d51265620cc759174e7...