Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: third_party/WebKit/Source/core/css/CSSGradientValue.cpp

Issue 2785203002: Split Gradient impl into separate classes (Closed)
Patch Set: review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSGradientValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSGradientValue.cpp b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
index cd88f91dc1192a174db90d029bf7937a42bd9937..9452b23cf42b65f8a242fc67c791345d2dcf0d58 100644
--- a/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
@@ -910,8 +910,8 @@ PassRefPtr<Gradient> CSSLinearGradientValue::createGradient(
addStops(desc, conversionData, object);
RefPtr<Gradient> gradient =
- Gradient::create(desc.p0, desc.p1, desc.spreadMethod,
- Gradient::ColorInterpolation::Premultiplied);
+ Gradient::createLinear(desc.p0, desc.p1, desc.spreadMethod,
+ Gradient::ColorInterpolation::Premultiplied);
// Now add the stops.
gradient->addColorStops(desc.stops);
@@ -1266,7 +1266,7 @@ PassRefPtr<Gradient> CSSRadialGradientValue::createGradient(
m_repeating ? SpreadMethodRepeat : SpreadMethodPad);
addStops(desc, conversionData, object);
- RefPtr<Gradient> gradient = Gradient::create(
+ RefPtr<Gradient> gradient = Gradient::createRadial(
desc.p0, desc.r0, desc.p1, desc.r1,
isDegenerate ? 1 : secondRadius.aspectRatio(), desc.spreadMethod,
Gradient::ColorInterpolation::Premultiplied);
@@ -1369,7 +1369,7 @@ PassRefPtr<Gradient> CSSConicGradientValue::createGradient(
DCHECK(!size.isEmpty());
// TODO(fmalita): implement
- return Gradient::create(FloatPoint(), FloatPoint());
+ return Gradient::createLinear(FloatPoint(), FloatPoint());
}
bool CSSConicGradientValue::equals(const CSSConicGradientValue& other) const {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698