Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

Issue 2785203002: Split Gradient impl into separate classes (Closed)
Patch Set: review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
index 15e865745b7ee9132c25e35a5e7ef7e1f0fef61d..c4f7f50f4b351da0a1cf5d56e23d9ac7f03a0884 100644
--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
@@ -1848,16 +1848,21 @@ void BaseRenderingContext2D::trackDrawCall(DrawCallType callType,
CanvasGradient* gradient = canvasStyle->getCanvasGradient();
if (gradient) {
- if (gradient->getGradient()->isRadial()) {
- m_usageCounters.numRadialGradients++;
- m_usageCounters.boundingBoxAreaFillType
- [BaseRenderingContext2D::RadialGradientFillType] +=
- boundingRectArea;
- } else {
- m_usageCounters.numLinearGradients++;
- m_usageCounters.boundingBoxAreaFillType
- [BaseRenderingContext2D::LinearGradientFillType] +=
- boundingRectArea;
+ switch (gradient->getGradient()->getType()) {
+ case Gradient::Type::Linear:
+ m_usageCounters.numLinearGradients++;
+ m_usageCounters.boundingBoxAreaFillType
+ [BaseRenderingContext2D::LinearGradientFillType] +=
+ boundingRectArea;
+ break;
+ case Gradient::Type::Radial:
+ m_usageCounters.numRadialGradients++;
+ m_usageCounters.boundingBoxAreaFillType
+ [BaseRenderingContext2D::RadialGradientFillType] +=
+ boundingRectArea;
+ break;
+ default:
+ NOTREACHED();
}
} else if (canvasStyle->getCanvasPattern()) {
m_usageCounters.numPatterns++;

Powered by Google App Engine
This is Rietveld 408576698