third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp - Issue 2785203002: Split Gradient impl into separate classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

Issue 2785203002: Split Gradient impl into separate classes (Closed)

Patch Set: review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSGradientValue.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceRadialGradient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

index 3c525aad8d7afe0ded1a0bbf2f5435b1c6baf404..e6db13e29d9f9ea9f7679a63980aa0cd24687b6e 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

@@ -52,7 +52,7 @@ FloatPoint LayoutSVGResourceLinearGradient::endPoint(

PassRefPtr<Gradient> LayoutSVGResourceLinearGradient::buildGradient() const {

const LinearGradientAttributes& attributes = this->attributes();

- RefPtr<Gradient> gradient = Gradient::create(

+ RefPtr<Gradient> gradient = Gradient::createLinear(

startPoint(attributes), endPoint(attributes),

platformSpreadMethodFromSVGType(attributes.spreadMethod()),

Gradient::ColorInterpolation::Unpremultiplied);