Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/modules/canvas2d/CanvasGradient.cpp

Issue 2785203002: Split Gradient impl into separate classes (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 Alp Toker <alp@atoker.com> 3 * Copyright (C) 2007 Alp Toker <alp@atoker.com>
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 16 matching lines...) Expand all
27 #include "modules/canvas2d/CanvasGradient.h" 27 #include "modules/canvas2d/CanvasGradient.h"
28 28
29 #include "bindings/core/v8/ExceptionState.h" 29 #include "bindings/core/v8/ExceptionState.h"
30 #include "core/dom/ExceptionCode.h" 30 #include "core/dom/ExceptionCode.h"
31 #include "modules/canvas2d/CanvasPattern.h" 31 #include "modules/canvas2d/CanvasPattern.h"
32 #include "modules/canvas2d/CanvasStyle.h" 32 #include "modules/canvas2d/CanvasStyle.h"
33 33
34 namespace blink { 34 namespace blink {
35 35
36 CanvasGradient::CanvasGradient(const FloatPoint& p0, const FloatPoint& p1) 36 CanvasGradient::CanvasGradient(const FloatPoint& p0, const FloatPoint& p1)
37 : m_gradient(Gradient::create(p0, p1)) {} 37 : m_gradient(Gradient::createLinear(p0, p1)), m_isZeroSize(p0 == p1) {}
38 38
39 CanvasGradient::CanvasGradient(const FloatPoint& p0, 39 CanvasGradient::CanvasGradient(const FloatPoint& p0,
40 float r0, 40 float r0,
41 const FloatPoint& p1, 41 const FloatPoint& p1,
42 float r1) 42 float r1)
43 : m_gradient(Gradient::create(p0, r0, p1, r1)) {} 43 : m_gradient(Gradient::createRadial(p0, r0, p1, r1)),
44 m_isZeroSize(p0 == p1 && r0 == r1) {}
44 45
45 void CanvasGradient::addColorStop(float value, 46 void CanvasGradient::addColorStop(float value,
46 const String& colorString, 47 const String& colorString,
47 ExceptionState& exceptionState) { 48 ExceptionState& exceptionState) {
48 if (!(value >= 0 && value <= 1.0f)) { 49 if (!(value >= 0 && value <= 1.0f)) {
49 exceptionState.throwDOMException( 50 exceptionState.throwDOMException(
50 IndexSizeError, "The provided value (" + String::number(value) + 51 IndexSizeError, "The provided value (" + String::number(value) +
51 ") is outside the range (0.0, 1.0)."); 52 ") is outside the range (0.0, 1.0).");
52 return; 53 return;
53 } 54 }
54 55
55 Color color = 0; 56 Color color = 0;
56 if (!parseColorOrCurrentColor(color, colorString, 0 /*canvas*/)) { 57 if (!parseColorOrCurrentColor(color, colorString, 0 /*canvas*/)) {
57 exceptionState.throwDOMException(SyntaxError, 58 exceptionState.throwDOMException(SyntaxError,
58 "The value provided ('" + colorString + 59 "The value provided ('" + colorString +
59 "') could not be parsed as a color."); 60 "') could not be parsed as a color.");
60 return; 61 return;
61 } 62 }
62 63
63 m_gradient->addColorStop(value, color); 64 m_gradient->addColorStop(value, color);
64 } 65 }
65 66
66 } // namespace blink 67 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasGradient.h ('k') | third_party/WebKit/Source/platform/graphics/Gradient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698