Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2782233002: Drop ntp_snippets::kStudyName in chrome://flags (Closed)

Created:
3 years, 8 months ago by sfiera
Modified:
3 years, 8 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop ntp_snippets::kStudyName in chrome://flags Also, remove the param that sets the content suggestions server. We no longer have support for anything else, but on Canary/Dev, it has the undesired behavior of switching away from the staging server. BUG=706347 Review-Url: https://codereview.chromium.org/2782233002 Cr-Commit-Position: refs/heads/master@{#460728} Committed: https://chromium.googlesource.com/chromium/src/+/0500d4a019aa88ef71d8685100e47d35a252f2a6

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add Java TODO #

Patch Set 4 : rebase #

Messages

Total messages: 26 (18 generated)
sfiera
3 years, 8 months ago (2017-03-29 16:19:56 UTC) #7
jkrcal
lgtm, thanks! Can you please add a TODO into the java code where the same ...
3 years, 8 months ago (2017-03-30 07:55:56 UTC) #11
sfiera
Done. +peconn for Java OWNERS
3 years, 8 months ago (2017-03-30 09:12:05 UTC) #13
Michael van Ouwerkerk
Drive-by java lgtm, thanks!
3 years, 8 months ago (2017-03-30 09:24:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782233002/40001
3 years, 8 months ago (2017-03-30 09:35:25 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/65853) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-03-30 09:37:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782233002/60001
3 years, 8 months ago (2017-03-30 11:16:11 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 11:59:39 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0500d4a019aa88ef71d8685100e4...

Powered by Google App Engine
This is Rietveld 408576698