Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: components/ntp_snippets/user_classifier_unittest.cc

Issue 2782233002: Drop ntp_snippets::kStudyName in chrome://flags (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/user_classifier_unittest.cc
diff --git a/components/ntp_snippets/user_classifier_unittest.cc b/components/ntp_snippets/user_classifier_unittest.cc
index f8f3a43a1aa06500c17dde7bbfca66f12f6114e5..882e7e6682b36acec6d780f6918fcafa1c6e7d08 100644
--- a/components/ntp_snippets/user_classifier_unittest.cc
+++ b/components/ntp_snippets/user_classifier_unittest.cc
@@ -90,7 +90,7 @@ TEST_F(UserClassifierTest,
ShouldBecomeActiveSuggestionsConsumerByClickingOftenWithDecreasedParam) {
// Increase the param to one half.
variations::testing::VariationParamsManager variation_params(
- kStudyName,
+ kArticleSuggestionsFeature.name,
{{"user_classifier_active_consumer_clicks_at_least_once_per_hours",
"36"}},
{kArticleSuggestionsFeature.name});
@@ -128,7 +128,7 @@ TEST_F(UserClassifierTest,
ShouldBecomeRareNtpUserByNoActivityWithDecreasedParam) {
// Decrease the param to one half.
variations::testing::VariationParamsManager variation_params(
- kStudyName,
+ kArticleSuggestionsFeature.name,
{{"user_classifier_rare_user_opens_ntp_at_most_once_per_hours", "48"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
@@ -230,7 +230,7 @@ TEST_P(UserClassifierMetricTest,
UserClassifier::Metric metric = GetParam().first;
// Increase the min_hours to 1.0, i.e. 60 minutes.
variations::testing::VariationParamsManager variation_params(
- kStudyName, {{"user_classifier_min_hours", "1.0"}},
+ kArticleSuggestionsFeature.name, {{"user_classifier_min_hours", "1.0"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
@@ -277,7 +277,7 @@ TEST_P(UserClassifierMetricTest,
UserClassifier::Metric metric = GetParam().first;
// Decrease the max_hours to 72, i.e. 3 days.
variations::testing::VariationParamsManager variation_params(
- kStudyName, {{"user_classifier_max_hours", "72"}},
+ kArticleSuggestionsFeature.name, {{"user_classifier_max_hours", "72"}},
{kArticleSuggestionsFeature.name});
UserClassifier* user_classifier = CreateUserClassifier();
« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698