components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc - Issue 2782233002: Drop ntp_snippets::kStudyName in chrome://flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

Issue 2782233002: Drop ntp_snippets::kStudyName in chrome://flags (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc ('k') | components/ntp_snippets/user_classifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

diff --git a/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

index a23d2506c31a990f44d75a528c7d43ec4be1efae..3ad44555729eee6d6dc9d63a0d5a28beaf16de76 100644

--- a/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

+++ b/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

@@ -106,7 +106,7 @@ class RemoteSuggestionsSchedulerImplTest : public ::testing::Test {

default_variation_params_{{"scheduler_trigger_types",

"persistent_scheduler_wake_up,ntp_opened,"

"browser_foregrounded,browser_cold_start"}},

- params_manager_(ntp_snippets::kStudyName,

+ params_manager_(ntp_snippets::kArticleSuggestionsFeature.name,

default_variation_params_,

{kArticleSuggestionsFeature.name}),

user_classifier_(/*pref_service=*/nullptr,

@@ -142,7 +142,7 @@ class RemoteSuggestionsSchedulerImplTest : public ::testing::Test {

params_manager_.ClearAllVariationParams();

params_manager_.SetVariationParamsWithFeatureAssociations(

- ntp_snippets::kStudyName, params,

+ ntp_snippets::kArticleSuggestionsFeature.name, params,

{ntp_snippets::kArticleSuggestionsFeature.name});

}