Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2782233002: Drop ntp_snippets::kStudyName in chrome://flags (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 nullptr}}; 567 nullptr}};
568 #endif // OS_ANDROID 568 #endif // OS_ANDROID
569 569
570 #if defined(OS_ANDROID) 570 #if defined(OS_ANDROID)
571 const FeatureEntry::FeatureVariation 571 const FeatureEntry::FeatureVariation
572 kContentSuggestionsNotificationsFeatureVariations[] = { 572 kContentSuggestionsNotificationsFeatureVariations[] = {
573 {"(notify always)", nullptr, 0, "3313312"}}; 573 {"(notify always)", nullptr, 0, "3313312"}};
574 #endif // OS_ANDROID 574 #endif // OS_ANDROID
575 575
576 #if defined(OS_ANDROID) 576 #if defined(OS_ANDROID)
577 const FeatureEntry::FeatureParam
578 kRemoteSuggestionsFeatureVariationContentSuggestionsServer[] = {
579 {"content_suggestions_backend",
580 ntp_snippets::kContentSuggestionsServer}};
581
582 const FeatureEntry::FeatureVariation kRemoteSuggestionsFeatureVariations[] = { 577 const FeatureEntry::FeatureVariation kRemoteSuggestionsFeatureVariations[] = {
583 {"via content suggestion server (backed by ChromeReader)", 578 {"via content suggestion server (backed by ChromeReader)", nullptr, 0,
584 kRemoteSuggestionsFeatureVariationContentSuggestionsServer,
585 arraysize(kRemoteSuggestionsFeatureVariationContentSuggestionsServer),
586 nullptr}, 579 nullptr},
587 {"via content suggestion server (backed by Google Now)", 580 {"via content suggestion server (backed by Google Now)", nullptr, 0,
588 kRemoteSuggestionsFeatureVariationContentSuggestionsServer,
589 arraysize(kRemoteSuggestionsFeatureVariationContentSuggestionsServer),
590 "3313279"}}; 581 "3313279"}};
591 #endif // OS_ANDROID 582 #endif // OS_ANDROID
592 583
593 #if defined(OS_ANDROID) 584 #if defined(OS_ANDROID)
594 const FeatureEntry::FeatureParam kCondensedTileLayoutForSmallScreensEnabled[] = 585 const FeatureEntry::FeatureParam kCondensedTileLayoutForSmallScreensEnabled[] =
595 {{"condensed_tile_layout_for_small_screens_enabled", "true"}}; 586 {{"condensed_tile_layout_for_small_screens_enabled", "true"}};
596 587
597 const FeatureEntry::FeatureParam kCondensedTileLayoutForLargeScreensEnabled[] = 588 const FeatureEntry::FeatureParam kCondensedTileLayoutForLargeScreensEnabled[] =
598 {{"condensed_tile_layout_for_large_screens_enabled", "true"}}; 589 {{"condensed_tile_layout_for_large_screens_enabled", "true"}};
599 590
(...skipping 1364 matching lines...) Expand 10 before | Expand all | Expand 10 after
1964 flag_descriptions::kDisableTabForDesktopShareDescription, kOsAll, 1955 flag_descriptions::kDisableTabForDesktopShareDescription, kOsAll,
1965 SINGLE_VALUE_TYPE(extensions::switches::kDisableTabForDesktopShare)}, 1956 SINGLE_VALUE_TYPE(extensions::switches::kDisableTabForDesktopShare)},
1966 #endif // ENABLE_EXTENSIONS 1957 #endif // ENABLE_EXTENSIONS
1967 #if defined(OS_ANDROID) 1958 #if defined(OS_ANDROID)
1968 {"content-suggestions-category-order", 1959 {"content-suggestions-category-order",
1969 flag_descriptions::kContentSuggestionsCategoryOrderName, 1960 flag_descriptions::kContentSuggestionsCategoryOrderName,
1970 flag_descriptions::kContentSuggestionsCategoryOrderDescription, kOsAndroid, 1961 flag_descriptions::kContentSuggestionsCategoryOrderDescription, kOsAndroid,
1971 FEATURE_WITH_PARAMS_VALUE_TYPE( 1962 FEATURE_WITH_PARAMS_VALUE_TYPE(
1972 ntp_snippets::kCategoryOrder, 1963 ntp_snippets::kCategoryOrder,
1973 kContentSuggestionsCategoryOrderFeatureVariations, 1964 kContentSuggestionsCategoryOrderFeatureVariations,
1974 ntp_snippets::kStudyName)}, 1965 ntp_snippets::kCategoryOrder.name)},
1975 {"content-suggestions-category-ranker", 1966 {"content-suggestions-category-ranker",
1976 flag_descriptions::kContentSuggestionsCategoryRankerName, 1967 flag_descriptions::kContentSuggestionsCategoryRankerName,
1977 flag_descriptions::kContentSuggestionsCategoryRankerDescription, 1968 flag_descriptions::kContentSuggestionsCategoryRankerDescription,
1978 kOsAndroid, 1969 kOsAndroid,
1979 FEATURE_WITH_PARAMS_VALUE_TYPE( 1970 FEATURE_WITH_PARAMS_VALUE_TYPE(
1980 ntp_snippets::kCategoryRanker, 1971 ntp_snippets::kCategoryRanker,
1981 kContentSuggestionsCategoryRankerFeatureVariations, 1972 kContentSuggestionsCategoryRankerFeatureVariations,
1982 ntp_snippets::kStudyName)}, 1973 ntp_snippets::kCategoryRanker.name)},
1983 {"enable-ntp-snippets-increased-visibility", 1974 {"enable-ntp-snippets-increased-visibility",
1984 flag_descriptions::kEnableNtpSnippetsVisibilityName, 1975 flag_descriptions::kEnableNtpSnippetsVisibilityName,
1985 flag_descriptions::kEnableNtpSnippetsVisibilityDescription, kOsAndroid, 1976 flag_descriptions::kEnableNtpSnippetsVisibilityDescription, kOsAndroid,
1986 FEATURE_VALUE_TYPE(ntp_snippets::kIncreasedVisibility)}, 1977 FEATURE_VALUE_TYPE(ntp_snippets::kIncreasedVisibility)},
1987 {"enable-content-suggestions-new-favicon-server", 1978 {"enable-content-suggestions-new-favicon-server",
1988 flag_descriptions::kEnableContentSuggestionsNewFaviconServerName, 1979 flag_descriptions::kEnableContentSuggestionsNewFaviconServerName,
1989 flag_descriptions::kEnableContentSuggestionsNewFaviconServerDescription, 1980 flag_descriptions::kEnableContentSuggestionsNewFaviconServerDescription,
1990 kOsAndroid, 1981 kOsAndroid,
1991 FEATURE_VALUE_TYPE(ntp_snippets::kPublisherFaviconsFromNewServerFeature)}, 1982 FEATURE_VALUE_TYPE(ntp_snippets::kPublisherFaviconsFromNewServerFeature)},
1992 {"enable-ntp-save-to-offline", 1983 {"enable-ntp-save-to-offline",
1993 flag_descriptions::kEnableNtpSaveToOfflineName, 1984 flag_descriptions::kEnableNtpSaveToOfflineName,
1994 flag_descriptions::kEnableNtpSaveToOfflineDescription, kOsAndroid, 1985 flag_descriptions::kEnableNtpSaveToOfflineDescription, kOsAndroid,
1995 FEATURE_VALUE_TYPE(ntp_snippets::kSaveToOfflineFeature)}, 1986 FEATURE_VALUE_TYPE(ntp_snippets::kSaveToOfflineFeature)},
1996 {"enable-ntp-offline-badge", flag_descriptions::kEnableNtpOfflineBadgeName, 1987 {"enable-ntp-offline-badge", flag_descriptions::kEnableNtpOfflineBadgeName,
1997 flag_descriptions::kEnableNtpOfflineBadgeDescription, kOsAndroid, 1988 flag_descriptions::kEnableNtpOfflineBadgeDescription, kOsAndroid,
1998 FEATURE_VALUE_TYPE(ntp_snippets::kOfflineBadgeFeature)}, 1989 FEATURE_VALUE_TYPE(ntp_snippets::kOfflineBadgeFeature)},
1999 {"enable-ntp-remote-suggestions", 1990 {"enable-ntp-remote-suggestions",
2000 flag_descriptions::kEnableNtpRemoteSuggestionsName, 1991 flag_descriptions::kEnableNtpRemoteSuggestionsName,
2001 flag_descriptions::kEnableNtpRemoteSuggestionsDescription, kOsAndroid, 1992 flag_descriptions::kEnableNtpRemoteSuggestionsDescription, kOsAndroid,
2002 FEATURE_WITH_PARAMS_VALUE_TYPE(ntp_snippets::kArticleSuggestionsFeature, 1993 FEATURE_WITH_PARAMS_VALUE_TYPE(
2003 kRemoteSuggestionsFeatureVariations, 1994 ntp_snippets::kArticleSuggestionsFeature,
2004 ntp_snippets::kStudyName)}, 1995 kRemoteSuggestionsFeatureVariations,
1996 ntp_snippets::kArticleSuggestionsFeature.name)},
2005 {"enable-ntp-recent-offline-tab-suggestions", 1997 {"enable-ntp-recent-offline-tab-suggestions",
2006 flag_descriptions::kEnableNtpRecentOfflineTabSuggestionsName, 1998 flag_descriptions::kEnableNtpRecentOfflineTabSuggestionsName,
2007 flag_descriptions::kEnableNtpRecentOfflineTabSuggestionsDescription, 1999 flag_descriptions::kEnableNtpRecentOfflineTabSuggestionsDescription,
2008 kOsAndroid, 2000 kOsAndroid,
2009 FEATURE_VALUE_TYPE(ntp_snippets::kRecentOfflineTabSuggestionsFeature)}, 2001 FEATURE_VALUE_TYPE(ntp_snippets::kRecentOfflineTabSuggestionsFeature)},
2010 {"enable-ntp-asset-download-suggestions", 2002 {"enable-ntp-asset-download-suggestions",
2011 flag_descriptions::kEnableNtpAssetDownloadSuggestionsName, 2003 flag_descriptions::kEnableNtpAssetDownloadSuggestionsName,
2012 flag_descriptions::kEnableNtpAssetDownloadSuggestionsDescription, 2004 flag_descriptions::kEnableNtpAssetDownloadSuggestionsDescription,
2013 kOsAndroid, 2005 kOsAndroid,
2014 FEATURE_VALUE_TYPE(features::kAssetDownloadSuggestionsFeature)}, 2006 FEATURE_VALUE_TYPE(features::kAssetDownloadSuggestionsFeature)},
(...skipping 16 matching lines...) Expand all
2031 flag_descriptions::kEnableNtpForeignSessionsSuggestionsDescription, 2023 flag_descriptions::kEnableNtpForeignSessionsSuggestionsDescription,
2032 kOsAndroid, 2024 kOsAndroid,
2033 FEATURE_VALUE_TYPE(ntp_snippets::kForeignSessionsSuggestionsFeature)}, 2025 FEATURE_VALUE_TYPE(ntp_snippets::kForeignSessionsSuggestionsFeature)},
2034 {"enable-ntp-suggestions-notifications", 2026 {"enable-ntp-suggestions-notifications",
2035 flag_descriptions::kEnableNtpSuggestionsNotificationsName, 2027 flag_descriptions::kEnableNtpSuggestionsNotificationsName,
2036 flag_descriptions::kEnableNtpSuggestionsNotificationsDescription, 2028 flag_descriptions::kEnableNtpSuggestionsNotificationsDescription,
2037 kOsAndroid, 2029 kOsAndroid,
2038 FEATURE_WITH_PARAMS_VALUE_TYPE( 2030 FEATURE_WITH_PARAMS_VALUE_TYPE(
2039 params::ntp_snippets::kNotificationsFeature, 2031 params::ntp_snippets::kNotificationsFeature,
2040 kContentSuggestionsNotificationsFeatureVariations, 2032 kContentSuggestionsNotificationsFeatureVariations,
2041 ntp_snippets::kStudyName)}, 2033 params::ntp_snippets::kNotificationsFeature.name)},
2042 {"ntp-condensed-layout", flag_descriptions::kNtpCondensedLayoutName, 2034 {"ntp-condensed-layout", flag_descriptions::kNtpCondensedLayoutName,
2043 flag_descriptions::kNtpCondensedLayoutDescription, kOsAndroid, 2035 flag_descriptions::kNtpCondensedLayoutDescription, kOsAndroid,
2044 FEATURE_VALUE_TYPE(chrome::android::kNTPCondensedLayoutFeature)}, 2036 FEATURE_VALUE_TYPE(chrome::android::kNTPCondensedLayoutFeature)},
2045 {"ntp-condensed-tile-layout", 2037 {"ntp-condensed-tile-layout",
2046 flag_descriptions::kNtpCondensedTileLayoutName, 2038 flag_descriptions::kNtpCondensedTileLayoutName,
2047 flag_descriptions::kNtpCondensedTileLayoutDescription, kOsAndroid, 2039 flag_descriptions::kNtpCondensedTileLayoutDescription, kOsAndroid,
2048 FEATURE_WITH_PARAMS_VALUE_TYPE( 2040 FEATURE_WITH_PARAMS_VALUE_TYPE(
2049 chrome::android::kNTPCondensedTileLayoutFeature, 2041 chrome::android::kNTPCondensedTileLayoutFeature,
2050 kNTPCondensedTileLayoutFeatureVariations, 2042 kNTPCondensedTileLayoutFeatureVariations,
2051 ntp_snippets::kStudyName)}, 2043 chrome::android::kNTPCondensedTileLayoutFeature.name)},
2052 {"ntp-google-g-in-omnibox", flag_descriptions::kNtpGoogleGInOmniboxName, 2044 {"ntp-google-g-in-omnibox", flag_descriptions::kNtpGoogleGInOmniboxName,
2053 flag_descriptions::kNtpGoogleGInOmniboxDescription, kOsAndroid, 2045 flag_descriptions::kNtpGoogleGInOmniboxDescription, kOsAndroid,
2054 FEATURE_VALUE_TYPE(chrome::android::NTPShowGoogleGInOmniboxFeature)}, 2046 FEATURE_VALUE_TYPE(chrome::android::NTPShowGoogleGInOmniboxFeature)},
2055 #endif // OS_ANDROID 2047 #endif // OS_ANDROID
2056 #if BUILDFLAG(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264) && \ 2048 #if BUILDFLAG(ENABLE_WEBRTC) && BUILDFLAG(RTC_USE_H264) && \
2057 !defined(MEDIA_DISABLE_FFMPEG) 2049 !defined(MEDIA_DISABLE_FFMPEG)
2058 {"enable-webrtc-h264-with-openh264-ffmpeg", 2050 {"enable-webrtc-h264-with-openh264-ffmpeg",
2059 flag_descriptions::kWebrtcH264WithOpenh264FfmpegName, 2051 flag_descriptions::kWebrtcH264WithOpenh264FfmpegName,
2060 flag_descriptions::kWebrtcH264WithOpenh264FfmpegDescription, kOsDesktop, 2052 flag_descriptions::kWebrtcH264WithOpenh264FfmpegDescription, kOsDesktop,
2061 FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)}, 2053 FEATURE_VALUE_TYPE(content::kWebRtcH264WithOpenH264FFmpeg)},
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
2698 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2690 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2699 2691
2700 const FeatureEntry* GetFeatureEntries(size_t* count) { 2692 const FeatureEntry* GetFeatureEntries(size_t* count) {
2701 *count = arraysize(kFeatureEntries); 2693 *count = arraysize(kFeatureEntries);
2702 return kFeatureEntries; 2694 return kFeatureEntries;
2703 } 2695 }
2704 2696
2705 } // namespace testing 2697 } // namespace testing
2706 2698
2707 } // namespace about_flags 2699 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698